Skip to content

[UI/UX] Redesign Settings with a System Settings–style sidebar - #30

Merged
ignaciojuarez merged 1 commit into
mainfrom
t3/7ef5a866
Nov 11, 2026
Merged

ignaciojuarez merged 1 commit into
mainfrom
t3/7ef5a866

Conversation

@ignaciojuarez

Copy link
Copy Markdown
Owner

Problem

Settings was hard to use. Nine toolbar tabs mixed unrelated controls: General held engines, backup, diagnostics and downloads; Browsing held search, tabs, automation, keyboard privacy and browser identity; Privacy hid three sub-pages behind a segmented control. Six panes each had their own profile picker, and long explanations sat in custom cards instead of native rows.

Change

  • System Settings–style window. A searchable icon sidebar (NavigationSplitView) and grouped native Form panes, with the pane title in the unified toolbar.
  • 14 focused panes in four groups: General · Appearance · Tabs · Search | Privacy & Security · Websites · History | Web Engines · Extensions · Profiles · iCloud Sync | Keyboard · Automation · Advanced.
  • Privacy & Security now holds website data, content blocking, keyboard privacy, and passwords and passkeys on one page. The site list moved into a searchable Manage Website Data… sheet with the existing per-category and time-range clearing.
  • Websites now holds per-site permissions, browser identity, and two newly exposed settings that were already stored but unreachable from Settings:
    • pop-ups per site (Allow/Block across engines that have a pop-up policy, applied without unloading pages);
    • remembered page zoom per site, with reset. Resetting a site with no other settings now drops its empty record.
  • Appearance exposes the existing tab loading-indicator preference.
  • Shared profile picker: profile-scoped panes use one picker. It defaults to the profile of the tab that opened Settings.
  • Settings recovery is a banner above every pane instead of a General-only group.
  • General shows "Cobble is your default browser" when that's true.
  • The old toolbar delegate and the custom card/row layout were removed; the sidebar organizer keeps a small local row.
  • Spanish translations were added for every new string. Docs and the changelog now point to the new pane names.

Tests

  • SiteSettingsTests.testSettingsPopupsCoverPopupEnginesAndZoomResetDropsEmptyEntries (new).
  • UITests.testSettingsRenderWithoutNetwork now drives every pane in light mode, plus three panes in dark mode and two at minimum size, with synthetic rows. It checks that the pane title appears in the window title, and that the content-blocker source follows profile reordering.
  • UITests.testGeneralSettingsToggleSavesAndRefreshes now uses the Web Engines pane and the recovery banner.

Validation

  • Full hosted suite (./Scripts/test.sh): 654 tests, 2 skipped, 1 failure. The failure was WebKitPageTests.testDisplayCaptureStopsThroughWebKitAndBlocksNativeMute (InvalidStateError from screen capture). It doesn't touch Settings code and passed when rerun alone.
  • swift build (Chromium native client) and adapter swift test: 12 tests, 0 failures.
  • Screenshots of every pane, taken from the real window with synthetic data, were reviewed by eye in light and dark mode and at minimum size.

Not qualified

  • The Manage Website Data sheet was not screenshotted.
  • A signed or notarized Full build, and the panes with Chromium registered (local runs used WebKit only).

🤖 Generated with Claude Code

Replace the nine-tab toolbar with a searchable icon sidebar and 14 grouped
native panes. Privacy & Security gathers website data, content blocking,
keyboard privacy and passkeys; website data moves into a searchable sheet.
Websites now manages per-site pop-ups and remembered zoom, Appearance exposes
the loading indicator, and one profile picker covers profile-scoped panes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ignaciojuarez
ignaciojuarez merged commit e90b5c5 into main Nov 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant