Repository navigation
[UI/UX] Redesign Settings with a System Settings–style sidebar - #30
Merged
Merged
Conversation
Replace the nine-tab toolbar with a searchable icon sidebar and 14 grouped native panes. Privacy & Security gathers website data, content blocking, keyboard privacy and passkeys; website data moves into a searchable sheet. Websites now manages per-site pop-ups and remembered zoom, Appearance exposes the loading indicator, and one profile picker covers profile-scoped panes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Settings was hard to use. Nine toolbar tabs mixed unrelated controls: General held engines, backup, diagnostics and downloads; Browsing held search, tabs, automation, keyboard privacy and browser identity; Privacy hid three sub-pages behind a segmented control. Six panes each had their own profile picker, and long explanations sat in custom cards instead of native rows.
Change
NavigationSplitView) and grouped nativeFormpanes, with the pane title in the unified toolbar.Tests
SiteSettingsTests.testSettingsPopupsCoverPopupEnginesAndZoomResetDropsEmptyEntries(new).UITests.testSettingsRenderWithoutNetworknow drives every pane in light mode, plus three panes in dark mode and two at minimum size, with synthetic rows. It checks that the pane title appears in the window title, and that the content-blocker source follows profile reordering.UITests.testGeneralSettingsToggleSavesAndRefreshesnow uses the Web Engines pane and the recovery banner.Validation
./Scripts/test.sh): 654 tests, 2 skipped, 1 failure. The failure wasWebKitPageTests.testDisplayCaptureStopsThroughWebKitAndBlocksNativeMute(InvalidStateErrorfrom screen capture). It doesn't touch Settings code and passed when rerun alone.swift build(Chromium native client) and adapterswift test: 12 tests, 0 failures.Not qualified
🤖 Generated with Claude Code