Repository navigation
[BUG] Show pages for links opened in background Chromium tabs - #32
Merged
Merged
Conversation
Chromium hides the view of a page it creates in the background (Open Link in New Tab, ⌘-click, middle-click) until Chrome's own view host shows it. Cobble hosts that view itself and never unhid it, so the tab stayed dark even though the page had loaded. Unhide the view when Cobble adopts it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Links opened in a background tab from a Chromium tab (right-click → Open Link in New Tab, ⌘-click, middle-click) stayed dark and never seemed to load, on every site.
Cause
The page did load, but its view was hidden. Chromium hides the view of any page it creates in the background, and Chrome's own view host un-hides it when the tab is shown. Cobble puts the view in its own window and never un-hid it. Foreground opens (⌘⇧-click) were unaffected. Beta 14 and 15 have the bug.
Fix
One line in
Engine/Chromium/ChromiumPage.swift: un-hide the page view when Cobble adds it to the tab. Plus a CHANGELOG line.Testing
Run in a separate session with a local Full build and an isolated data folder for each run:
swift test: 13 Chromium adapter tests pass.🤖 Generated with Claude Code