Skip to content

[BUG] Stop HTTP links that fail HTTPS upgrade from crashing Cobble - #34

Merged
ignaciojuarez merged 1 commit into
mainfrom
t3/fix-mail-link-crash
Nov 15, 2026
Merged

ignaciojuarez merged 1 commit into
mainfrom
t3/fix-mail-link-crash

Conversation

@ignaciojuarez

Copy link
Copy Markdown
Owner

Opening an http:// link (here, an email tracking link) in a Chromium tab quit Cobble whenever the site could not be reached over HTTPS.

Cause: The beta 16 crash report, symbolicated with the matching dSYM, shows a CHECK failure. Chromium 157's HTTPS-First fallback calls AskBeforeHttpDialogController::ShowDialog, which leads to TabDialogManager::CreateTabScopedDialog and CHECK(host). Cobble's host-owned windows have no Chrome widget for that dialog.

Fix: Pin chrome-sdk 2d09b63 (chrome-sdk#25), which shows Chromium's full-page interstitial in the tab instead. No ABI change.

Verified:

  • SDK source tests pass. The native rebuild and package passed, and so did the SDK smoke.
  • A local Full build with this runtime opened the failing http:// host in a Chromium tab, used isolated data, showed "url3038.axs.com doesn't support a secure connection with HTTPS", stayed running, and loaded the site after Continue.
  • Not verified: the Developer ID release build.

🤖 Generated with Claude Code

Opening an http:// link (e.g. an email tracking link) in a Chromium tab
quit Cobble when the site could not be reached over HTTPS. Chromium 157
tried to show its Ask-before-HTTP dialog, which cannot attach to Cobble's
window.

- Pin chrome-sdk 2d09b63, which shows Chromium's full-page interstitial
  in the tab instead, with Continue to site.
- CHROMIUM.md records the cause and what was verified.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ignaciojuarez
ignaciojuarez merged commit 046c78d into main Nov 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant