Repository navigation
[BUG] Stop HTTP links that fail HTTPS upgrade from crashing Cobble - #34
Merged
Merged
Conversation
Opening an http:// link (e.g. an email tracking link) in a Chromium tab quit Cobble when the site could not be reached over HTTPS. Chromium 157 tried to show its Ask-before-HTTP dialog, which cannot attach to Cobble's window. - Pin chrome-sdk 2d09b63, which shows Chromium's full-page interstitial in the tab instead, with Continue to site. - CHROMIUM.md records the cause and what was verified. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an
http://link (here, an email tracking link) in a Chromium tab quit Cobble whenever the site could not be reached over HTTPS.Cause: The beta 16 crash report, symbolicated with the matching dSYM, shows a CHECK failure. Chromium 157's HTTPS-First fallback calls
AskBeforeHttpDialogController::ShowDialog, which leads toTabDialogManager::CreateTabScopedDialogandCHECK(host). Cobble's host-owned windows have no Chrome widget for that dialog.Fix: Pin chrome-sdk
2d09b63(chrome-sdk#25), which shows Chromium's full-page interstitial in the tab instead. No ABI change.Verified:
http://host in a Chromium tab, used isolated data, showed "url3038.axs.com doesn't support a secure connection with HTTPS", stayed running, and loaded the site after Continue.🤖 Generated with Claude Code