Skip to content

fix(ace-step): preserve manually scaled replicas #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
igou-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(ace-step): preserve manually scaled replicas #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions applications/ace-step/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ pod also carries the burst nodeSelector and `workload=burst` toleration.

Claiming both GPUs means ComfyUI and casval-hosted llmkube models
(`qwen3-35b`, `qwen38-27b`) cannot run concurrently. Scale those to `0`
before leaving ACE-Step at `1`.
before starting ACE-Step.

ArgoCD ignores `/spec/replicas` so a live scale-down is not reverted.
ArgoCD ignores `/spec/replicas` and uses `RespectIgnoreDifferences=true`, so
a live scale-down is not reverted during sync.

## Persistence

Expand Down
2 changes: 1 addition & 1 deletion applications/ace-step/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ helmCharts:
controllers:
ace-step:
type: deployment
replicas: 1
replicas: 0
# Exclusive nvidia.com/gpu: 2 — a rolling update would deadlock
# waiting for a second pair of GPUs that casval does not have.
strategy: Recreate
Expand Down
4 changes: 3 additions & 1 deletion clusters/ocp/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,9 @@ applications:
source:
path: applications/ace-step
# Replicas are scaled manually. Leave them alone so ArgoCD does not
# revert a scale-down back to the 1 checked into git.
# revert a scale-down back to the 0 checked into git.
syncOptions:
- RespectIgnoreDifferences=true
ignoreDifferences:
- group: apps
kind: Deployment
Expand Down