Set image labels based on repository info#79
Open
RaphvK wants to merge 8 commits into
Open
Conversation
Member
Author
|
As discussed with @lreiher and @jpbusch:
|
Member
Author
Changes implemented as discussed and ready for review @lreiher @jpbusch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64
Currently, all images created in the docker-ros workflow inherit the following image labels from the base image (when used with default docker-ros-ml-images):
{ "maintainer":"Institute for Automotive Engineering (ika), RWTH Aachen University <opensource@ika.rwth-aachen.de>", "org.opencontainers.image.authors":"Institute for Automotive Engineering (ika), RWTH Aachen University <opensource@ika.rwth-aachen.de>", "org.opencontainers.image.licenses":"MIT", "org.opencontainers.image.url":"https://github.com/ika-rwth-aachen/docker-ros-ml-images", "org.opencontainers.image.version":"26.04" }This PR extends the build scripts and Dockerfile so that the following labels are overridden:
LICENSEfile in root of repository if present, empty string otherwiseAll values can be overriden using CI environment variables.
Tests