Add basic security headers to HTTP status server (#186)#202
Merged
Conversation
Wrap the WAI application with middleware that sets X-Content-Type-Options: nosniff, X-Frame-Options: DENY, and Cache-Control: no-store on every response. Defence in depth against accidental browser access to operator-facing endpoints; cluster state snapshots also stay out of intermediate caches. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 97.14% 97.17% +0.02%
==========================================
Files 50 50
Lines 8066 8148 +82
==========================================
+ Hits 7836 7918 +82
Misses 230 230 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withSecurityHeadersmiddleware that setsX-Content-Type-Options: nosniff,X-Frame-Options: DENY, andCache-Control: no-storeon every response (including 404 / 405).securityHeaders,withSecurityHeaders, andsecuredHttpAppfromPureMyHA.HTTP.Server;startHTTPServernow serves throughsecuredHttpApp./health,/cluster/e2e/status, and/metrics.docs/http-api.md.Closes #186.
Test plan
cabal build all(with-Werror)cabal test— 617 examples, 0 failuresmake e2e-test T=13— 25 passed, 0 failed (includes 9 new header assertions)🤖 Generated with Claude Code