fix(runtime): require complete braced environment references - #647
Merged
Merged
Conversation
ilbertt
enabled auto-merge (squash)
September 29, 2026 15:54
ilbertt
added a commit
to ilbertt/nibrunner
that referenced
this pull request
Sep 30, 2026
Expand only complete `${NIBRUN_NAME}` references, preserving bare names
and incomplete references in secrets, matching
ilbertt/nibrun#647. Intentional bare references
now need braces; complete unknown or unavailable references still fail.
Validation: `just fmt`, `just lint`, `just test`, `just integration
--no-run`, and `just check-schema` passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand only complete
${NIBRUN_NAME}references so bare dollar signs, braces, and incomplete references reach the tenant unchanged. Keep validation and public-port detection consistent, with regression coverage for secrets and mixed literal/reference values.Intentional bare
$NIBRUN_NAMEreferences now need braces. Complete references to unknown runtime names are still rejected.Validation:
bun fix:codestyle,bun check:all(including Docker runtime tests), andbun run buildpassed.