feat: Windows MSI in CI and GitHub Releases - #7
Merged
Conversation
Stage sidecar with a host-aware Node script so onnxruntime keeps win32 binaries. PR CI bundles MSI; tag workflow uploads a signed MSI onto the same GitHub Release as Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Linux already builds unsigned AppImage/deb/rpm on PRs and ships signed artifacts on
v*tags. Windows CI only compiled--no-bundle. This adds the same split for MSI so we can evaluate packaging before treating Windows as a product.What
scripts/prepare-sidecar-bundle.js— host-aware sidecar staging (keep this-OS onnxruntime only).beforeBundleCommandruns it via Node so Windows CI does not needsh.ci-windows.yml— unsignedtauri build -b msion PRs/master.release-windows.yml— onv*,tauri-action-b msiwith updater artifacts, same tag/secrets as Linux so the MSI lands on the existing release and merges intolatest.json.npm run build:msifor a Windows host. Defaultbundle.targetsstaysdeb.Evaluate
.msi(workflowci-windows).win32on the Windows runner (and still strips foreign ORT on Linux).