добавлен Service Worker - #36
Open
bulgakovd97 wants to merge 5 commits into
Open
Conversation
it-ptitsa
approved these changes
Jul 16, 2023
added 2 commits
July 16, 2023 21:35
| import App from './App'; | ||
| import ReactDOM from 'react-dom/client'; | ||
|
|
||
| const startServiceWorker = () => { |
There was a problem hiding this comment.
Предлагаю декомпозировать и вынести регистрацию в отдельный модуль (файл)
Дополнительно:
При взаимодействии с асинхронной логикой пользуемся async / await + try / catch
https://learn.javascript.ru/async-await#:~:text=%D0%A2%D0%B0%D0%BA%D0%B8%D0%B5%20%D0%BE%D1%88%D0%B8%D0%B1%D0%BA%D0%B8%20%D0%BC%D0%BE%D0%B6%D0%BD%D0%BE%20%D0%BB%D0%BE%D0%B2%D0%B8%D1%82%D1%8C%2C%20%D0%B8%D1%81%D0%BF%D0%BE%D0%BB%D1%8C%D0%B7%D1%83%D1%8F%20try..catch%2C%20%D0%BA%D0%B0%D0%BA%20%D1%81%20%D0%BE%D0%B1%D1%8B%D1%87%D0%BD%D1%8B%D0%BC%20throw
|
|
||
| const url = new URL(request.url); | ||
|
|
||
| if (url.origin === location.origin) { |
There was a problem hiding this comment.
Рекомендация: при использовании if стараться оставлять структуру без ветвлений
if () {
...
return
}
// else
| ]; | ||
|
|
||
| sw.addEventListener('install', (event) => { | ||
| console.log('install', event); |
added 2 commits
July 17, 2023 01:25
IvanPeleshok
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавление Service Workers
Скриншоты/видяшка (если есть)
TBD (если есть)