Feature/lfo2 - #6
Merged
Merged
Conversation
- Add lfo2_waveform, lfo2_division, lfo2_depth, lfo2_dest fields to SynthParams - Add Lfo2Waveform, Lfo2Division, Lfo2Depth, Lfo2Dest control field variants - Wire LFO2 DSP modulation in engine for both Synth A and Synth B - Update UI layout: AMP | LFO1 | LFO2 (3-column bottom row) - Update mouse hit-testing for 3-column LFO layout - Update keyboard navigation (AMP + LFO1 + LFO2 in single row) - LFO2 defaults: Sine, 1/4 note, depth 0 (off), dest Osc1Tune (vibrato) - Same 11 assignable destinations as LFO1 - Backward compatible: serde(default) for all new fields Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Layout now: AMP (left 50%) | LFO1 over LFO2 (right 50%, stacked). Updated both rendering and mouse hit-testing to match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Names now distinguish Osc1 vs Osc2 params: O1Tune, O2Tune, O1PWM, etc. Previously both showed as "Tune", "PWM", "Level" making it look like only a few targets were available. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The mouse click handler for enum fields was using max_val=3 for all non-FilterType fields, causing LFO dest to only cycle through 4 of 11 targets and LFO waveform through 4 of 6. Now uses correct max for each: - LFO waveform: 5 (6 waveforms) - LFO division: 17 (18 beat divisions) - LFO dest: 10 (11 targets) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.