fix: launch Terminal=true apps in a terminal emulator from app launcher - #150
Open
iamjoshuanicholas wants to merge 1 commit into
Open
fix: launch Terminal=true apps in a terminal emulator from app launcher#150iamjoshuanicholas wants to merge 1 commit into
iamjoshuanicholas wants to merge 1 commit into
Conversation
Quickshell's DesktopEntry type exposes runInTerminal but does not automatically wrap the exec command in a terminal, even when the .desktop file sets Terminal=true. This caused terminal-based apps to silently fail to launch from the app launcher. - app_fetcher.py now parses Terminal=true/1 from .desktop files and includes it in the JSON output as a 'terminal' field - appLauncher.qml's launchApp() now accepts the full app object, checks the terminal flag, and wraps the exec in 'kitty -e' when set
|
What happens if the user uses another terminal, such as Alacritty? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Terminal-based apps (anything with
Terminal=truein their .desktop entry) silently fail to launch from the app launcher. This is a known Quickshell limitation —DesktopEntry.runInTerminalis exposed but never automatically wrapped into the exec command, so shells built on Quickshell need to handle it themselves.Fix
app_fetcher.pynow parsesTerminal=true/Terminal=1from .desktop files and includes it as aterminalfield in the JSON outputappLauncher.qml'slaunchApp()now receives the full app object (instead of just the exec string), checks theterminalflag, and wraps the command inkitty -ewhen setTesting
Confirmed terminal apps now launch correctly from the launcher, both via Enter key and mouse click. Non-terminal apps unaffected.