Expand guided native setup orchestration#246
Conversation
ilysenko
left a comment
There was a problem hiding this comment.
Thanks, this is useful, but I found two issues that should be fixed before merge.
First, make setup-native can hang while printing Computer Use readiness. On my machine the wizard stops in uinput_summary() because stat -c '%A %U:%G' /dev/uinput does not return (timeout 3 stat ... exits 124). Since this is only diagnostic output, please make it bounded/fail-soft, for example by wrapping it with a short timeout or skipping the extra stat metadata when it cannot be read quickly.\n\nSecond, dry-run cleanup still requires an interactive TTY. The docs say CODEX_BOOTSTRAP_DRY_RUN=1 previews cleanup targets without deleting them, but run_feature_cleanup() exits with “Cleanup requires an interactive terminal...” before confirm_and_delete_path() can print Would delete. Please allow non-interactive cleanup when dry-run is enabled, and keep the TTY/exact confirmation requirement only for real deletion. A smoke test for non-interactive dry-run cleanup would be good too.
ilysenko
left a comment
There was a problem hiding this comment.
Thanks, the requested fixes are in place now.
Summary
make setup-nativewith explicit opt-in orchestration for dependency bootstrap and native install commands, including dry-run outputDELETE <path>confirmation before removing feature-owned local dataNotes
This builds on #244 and keeps
make bootstrap-native,make install-native,make package, andmake installnon-interactive. The wizard still avoids changing system services, groups, key files, model files, Python runtimes, or plugin caches unless the user explicitly opts into the relevant step.Test plan
bash -n scripts/bootstrap-wizard.shgit diff --check origin/main...HEADnode --test linux-features/*/test.jsbash tests/scripts_smoke.sh