Skip to content

Expand guided native setup orchestration#246

Merged
ilysenko merged 4 commits into
ilysenko:mainfrom
PinguuSS:build/setup-native-guided-next
May 20, 2026
Merged

Expand guided native setup orchestration#246
ilysenko merged 4 commits into
ilysenko:mainfrom
PinguuSS:build/setup-native-guided-next

Conversation

@PinguuSS
Copy link
Copy Markdown
Contributor

Summary

  • extend make setup-native with explicit opt-in orchestration for dependency bootstrap and native install commands, including dry-run output
  • add deeper read-only readiness guidance for Computer Use and Read Aloud paths, packages, services, and doctor commands
  • add a separate interactive cleanup path that requires exact DELETE <path> confirmation before removing feature-owned local data

Notes

This builds on #244 and keeps make bootstrap-native, make install-native, make package, and make install non-interactive. The wizard still avoids changing system services, groups, key files, model files, Python runtimes, or plugin caches unless the user explicitly opts into the relevant step.

Test plan

  • bash -n scripts/bootstrap-wizard.sh
  • git diff --check origin/main...HEAD
  • node --test linux-features/*/test.js
  • bash tests/scripts_smoke.sh

@PinguuSS PinguuSS marked this pull request as ready for review May 19, 2026 20:40
Copy link
Copy Markdown
Owner

@ilysenko ilysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is useful, but I found two issues that should be fixed before merge.

First, make setup-native can hang while printing Computer Use readiness. On my machine the wizard stops in uinput_summary() because stat -c '%A %U:%G' /dev/uinput does not return (timeout 3 stat ... exits 124). Since this is only diagnostic output, please make it bounded/fail-soft, for example by wrapping it with a short timeout or skipping the extra stat metadata when it cannot be read quickly.\n\nSecond, dry-run cleanup still requires an interactive TTY. The docs say CODEX_BOOTSTRAP_DRY_RUN=1 previews cleanup targets without deleting them, but run_feature_cleanup() exits with “Cleanup requires an interactive terminal...” before confirm_and_delete_path() can print Would delete. Please allow non-interactive cleanup when dry-run is enabled, and keep the TTY/exact confirmation requirement only for real deletion. A smoke test for non-interactive dry-run cleanup would be good too.

Copy link
Copy Markdown
Owner

@ilysenko ilysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the requested fixes are in place now.

@ilysenko ilysenko merged commit dd8ee20 into ilysenko:main May 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants