Fix multi-instance launches for packaged community users#250
Closed
avifenesh wants to merge 2 commits into
Closed
Conversation
Expose a desktop Open New Instance action, skip warm-start handoff when multi-launch is active, and terminate orphaned webview servers when the launcher dies so ports stay available. Co-authored-by: Cursor <cursoragent@cursor.com>
Uses a temp copy of the side-by-side dev app with a mock Electron binary so launcher multi-launch behavior can be verified without touching production codex-app. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@Leay15 Im sorry, claude making me misrable. soon. |
Collaborator
|
@avifenesh No worries 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CODEX_MULTI_LAUNCH=1and--new-instance) so users can launch a second Codex process from the launcher right-click menu without knowing CLI flags.--new-instancerequest.PR_SET_PDEATHSIG(SIGTERM)in the embedded webview HTTP server so orphaned servers cannot permanently block webview ports after a crashed or killed launcher.Builds on the bootstrap lock bypass from #229. Normal icon clicks still focus the existing instance by design; this PR makes the opt-in multi-instance path discoverable and more reliable for packaged installs.
Test plan
node --test scripts/patch-linux-window-ui.test.js(125/125 pass)python3 -c "import py_compile; py_compile.compile('launcher/webview-server.py')"codex-desktop --new-instancewith an existing instance runningkill -9and confirm webview port is released within ~2sMade with Cursor