[codex] Fix Read Aloud setup fallback readiness#251
Merged
ilysenko merged 2 commits intoMay 20, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #234.
What changed
This tightens the Read Aloud setup path so the settings UI reports readiness only when a speech backend can actually run:
CODEX_LINUX_READ_ALOUD_KOKORO_PYTHONinto the app-side Kokoro runnerkokoro-stdinonPATHXDG_RUNTIME_DIRis missingspd-say/espeak-ngfallback available by default inside the already opt-in feature, withCODEX_LINUX_READ_ALOUD_NATIVE_FALLBACK=0as the opt-outspd-say -t female1; use the distro default unless the user explicitly setsCODEX_LINUX_READ_ALOUD_VOICE_TYPEWhy
A user report in #234 showed the setting could be enabled and the model installed manually, but clicking the speech icon still produced no sound. The previous setup flow could also return
ok: trueafter only selecting model files, even when Python,aplay, the runner, or a native fallback were not available.The settings UI also had duplicate surfaces: the dedicated Read Aloud section plus a normal/general settings row. This keeps the feature in one clear settings location.
Validation
node --test linux-features/read-aloud/test.js linux-features/read-aloud-mcp/test.jscargo test -p codex-read-aloud-linuxcargo check -p codex-read-aloud-linuxbash -n linux-features/read-aloud/install-kokoro-runtime.shnode --check linux-features/read-aloud/patch.jsgit diff --checknode --test linux-features/*/test.js