Fix multi-time automation RRULE scheduling#304
Merged
Conversation
- Add a core extracted-app patch for automation schedule helpers - Expand weekly and daily RRULE evaluation across BYHOUR and BYMINUTE combinations - Cover multi-hour weekday schedules with idempotent patch tests
ilysenko
approved these changes
May 24, 2026
Owner
ilysenko
left a comment
ilysenko
left a comment
There was a problem hiding this comment.
Reviewed the extracted-app RRULE patch, focused automation schedule tests, idempotency behavior, and current CI/upstream-build results. No blockers found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-visible behavior
Automation RRULEs such as weekdays at 11:00, 14:00, 17:00, and 20:00 now advance to the next same-day time instead of collapsing to the first BYHOUR value and skipping the remaining times.
Validation