Allow Browser plugin file URLs on Linux#305
Closed
VrtxOmega wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for working on this. I am going to close this PR because we fixed the issue in #306 with a narrower patch and tests against the current upstream bundle shape. The main problems with this PR were:
Closing this in favor of #306. Thanks again for identifying the issue and pushing the first fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser-client.mjsURL policy so advertised localfile://targets are allowed on Linux.data:URLs blocked by the upstream policy.Context
Fixes #268. The Browser plugin description advertises local
file://support, but the bundled Browser client only allowedhttp:andhttps:afterabout:blank. This keeps the policy narrow by addingfile:only for the staged Browser plugin path.Validation
bash -n scripts/lib/bundled-plugins.sh tests/scripts_smoke.shgit diff --checktest_browser_use_node_repl_fallback_runtime; test_browser_plugin_renamed_upstream_stagingenv -i HOME="$HOME" PATH="$PATH" USER="$USER" SHELL="$SHELL" TERM="${TERM:-xterm}" bash tests/scripts_smoke.sh