Add Linux AppShots support#307
Open
moxw wants to merge 3 commits into
Open
Conversation
- Enable AppShots availability and hotkey routing on Linux - Capture focused Linux windows through the Computer Use backend - Add screenshot CLI fallbacks plus Rust and patcher tests - Document Linux AppShots usage and backend commands
- Elide redundant AppShot helper lifetimes - Use direct length comparison for capped lines
Owner
|
Thanks for working on this. The idea is useful, but I do not think AppShots should land as an always-on core patch right now. Please move the Linux AppShots UI exposure/settings/hotkey patches into an opt-in Main reasons:
I would be happy with this as an optional |
- Move AppShots patch descriptors into linux-features/appshots - Fail closed without focused-window crop or portal-backed capture - Disable the Linux global hotkey default and document opt-in use
Contributor
Author
|
Thanks, addressed in the latest push. What changed:
Local validation passed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-visible behavior
Validation