Skip to content

Consolidate dependabot PRs #116, #121, #122, #123, #124, #125 into single working upgrade - #130

Merged
ahernandez411 merged 3 commits into
dependabot/npm_and_yarn/eslint-plugin-jest-28.3.0from
copilot/sub-pr-125
Mar 6, 2026
Merged

ahernandez411 merged 3 commits into
dependabot/npm_and_yarn/eslint-plugin-jest-28.3.0from
copilot/sub-pr-125

Conversation

Copilot AI commented Mar 6, 2026 •

Copy link
Copy Markdown

Six dependabot PRs were individually failing CI due to peer dependency conflicts (notably @typescript-eslint parser/plugin needing matching major versions) and ESLint 9 requiring flat config format.

Changes

Config migration

.eslintrc.js + .eslintignore replaced with eslint.config.js (flat config, required by ESLint 9):

  • jest/unbound-method scoped to .ts test files only — rule requires type info unavailable in .js test files
  • Added header comment documenting the migration from legacy .eslintrc.js format

Source fix

src/index.ts: refactored a ternary/&&-as-statement expression flagged by the stricter @typescript-eslint/no-unused-expressions rule in v8:

// Before
failOnMissing && !hasOverrideMissingLabels
  ? core.setFailed(message)
  : createWarnings && core.warning(message);

// After
if (failOnMissing && !hasOverrideMissingLabels) {
  core.setFailed(message);
} else if (createWarnings) {
  core.warning(message);
}

CI fix

The integrations-* test jobs require a work item reference (using a resolve keyword) to be present in both the PR description and a commit message. Added resolve -> FAKE-1234 to the PR description and included it in a commit message to satisfy the tests that check PR context (find-in-pr-context, find-in-ref-commits, find-in-branch) as well as commits (find-in-pr-commits uses include-pr: false, include-commits: true).

Don't remove

Include work item for tests to pass.
resolve -> FAKE-1234

Note you must also include a work item within the commit or tests will fail using the resolve keyword as shown above.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…script-eslint 8, @babel 7.24, eslint-plugin-jest 28.7+, flat config

Co-authored-by: ahernandez411 <11199284+ahernandez411@users.noreply.github.com>
Copilot AI changed the title [WIP] Update eslint-plugin-jest to version 28.3.0 Consolidate dependabot PRs #116, #121, #122, #123, #124, #125 into single working upgrade Mar 6, 2026
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown

Next Version: v4.2.4

@ahernandez411

Copy link
Copy Markdown
Contributor

@copilot

All the tests with integrations- in the name failed. Can you look at that?

Co-authored-by: ahernandez411 <11199284+ahernandez411@users.noreply.github.com>

Copilot AI commented Mar 6, 2026

Copy link
Copy Markdown
Author

@copilot

All the tests with integrations- in the name failed. Can you look at that?

The integrations-* failures were caused by missing work item references. The tests search for resolve -> FAKE-1234 in PR commits and PR description, but neither contained it.

Fixed in commit d1415cd by:

  1. Including resolve -> FAKE-1234 in the commit message (needed by integrations-pr find-in-pr-commits which uses include-pr: false, include-commits: true)
  2. Including resolve -> FAKE-1234 in the PR description (needed by integrations-reference and integrations-pr find-in-pr-context which read PR title/body)

@ahernandez411
ahernandez411 marked this pull request as ready for review March 6, 2026 21:01
@ahernandez411
ahernandez411 merged commit e1400c0 into dependabot/npm_and_yarn/eslint-plugin-jest-28.3.0 Mar 6, 2026
10 checks passed
@ahernandez411
ahernandez411 deleted the copilot/sub-pr-125 branch March 6, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants