Added drag and drop in update panel for firefox#327
Open
23f2004548 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the upload drop zone drag-over behavior so the browser indicates a “copy” operation when files are dragged onto the panel.
Changes:
- Sets
dataTransfer.dropEffect = "copy"duringonDragOverto improve user feedback while dragging files.
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+37
to
+38
| onDragEnter={e=>{e.dataTransfer.dropEffect = "copy";setDragging(true)}} | ||
| onDragOver={e=>e.preventDefault()} |
Comment on lines
+37
to
39
| onDragEnter={e=>{e.dataTransfer.dropEffect = "copy";setDragging(true)}} | ||
| onDragOver={e=>e.preventDefault()} | ||
| onDragLeave={()=>setDragging(false)} |
Owner
|
@23f2004548 add demo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR title:
fix(upload-panel): set dropEffect during dragover for Firefox
FIXES #101
PR description:
Set e.dataTransfer.dropEffect = "copy" in frontend/src/components/UploadPanel.jsx onDragOver to fix drag-and-drop in Firefox. Test by dragging a file into the upload panel in Firefox.