Skip to content

fix(chat): clear stuck 'typing...' cursor on empty/hung streaming responses (#228) #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Guciolek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(chat): clear stuck 'typing...' cursor on empty/hung streaming responses (#228) #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion frontend/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,17 @@ export default function App() {
setStreaming(true);
const aiMsg = { role: "assistant", content: "", sources: [], id: Date.now() + 1, streaming: true };
setMessages(prev => [...prev, aiMsg]);
// Safety timeout: if the server hangs or returns no tokens for 60s,
// force the "typing..." cursor away and show a fallback message.
// Prevents stuck UI on empty/hung streaming responses (issue #228).
const safetyTimeout = setTimeout(() => {
setMessages(prev => prev.map(m =>
m.id === aiMsg.id && m.streaming
? { ...m, content: m.content || "(empty response)", streaming: false }
: m
));
setStreaming(false);
}, 60000);
try {
await api.streamMessage(
{ message: text, session_id: sessionId, model, use_documents: documents.length > 0, language },
Expand All @@ -69,7 +80,18 @@ export default function App() {
);
} catch (e) {
setMessages(prev => prev.map(m => m.id === aiMsg.id ? { ...m, content: e.message, streaming: false } : m));
} finally { setStreaming(false); }
} finally {
clearTimeout(safetyTimeout);
// Safety net: if streaming is still true after the await returns,
// force-clear it so the cursor doesn't get stuck. This covers edge
// cases where the server returns 200 OK with an empty body.
setMessages(prev => prev.map(m =>
m.id === aiMsg.id && m.streaming
? { ...m, content: m.content || "(empty response)", streaming: false }
: m
));
setStreaming(false);
}
} else {
setLoading(true);
try {
Expand Down