Open
Conversation
Intent of this dockerfile is to build ImageJ locally without downloading any pre-built versions (zips or update sites). This strategy can be repeated in down- stream repositories either by following a similar strategy or by using this built image as a parent.
Member
|
@joshmoore Sorry for ignoring this for so long. Is this still useful to you if we merge? And/or would it make sense to create an imagej/dockerfiles repository and put this there? |
Member
Author
No worries. I have several tabs open to come back and look into xvfb integration. And which point, this might again be useful.
This is really the core question, and I'm unsure. The tradeoffs are:
If there's no desire to have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent of this dockerfile is to build ImageJ locally
without downloading any pre-built versions (zips or
update sites). This strategy can be repeated in down-
stream repositories either by following a similar
strategy or by using this built image as a parent.
Status (post-
#hackdd17)bin/populate-app.shlooks to currently not configure a Java runtime:--build-arg IMAGE=openjdk:8--build-arg IMAGE=openjdk:9--build-arg IMAGE=openjdk:9(with new launcher)See http://forum.imagej.net/t/please-test-the-new-imagej-launcher/8238/18
This is injected to the dockerfile just before
ENTRYPOINT:Results:
but
--build-arg IMAGE=centos:7