Fix Windows drive environment overrides - #855
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
=C:=...) by their drive key instead of collapsing every leading-=entry to an empty keyCreateProcessWRed-to-green evidence
Before the utility source change, the new MSVC Debug regression test built and failed with:
After the fix, the directly affected tests pass on:
utility_test,spawn_wait_test(spawn_detached_testis a passing POSIX-only skip on Windows)utility_test,spawn_detached_test,spawn_wait_testAdditional broad observations
Optional Windows all-active builds completed for Debug and Release. Each concurrent once-through ran 130 invocations and produced 129 passes plus one unrelated managed-child timing/setup miss. The Debug crash-provenance contract then passed 4 consecutive focused runs; the Release readiness-deadline contract passed 3 consecutive focused runs. Both environment-related tests passed in the broad runs. These observations are reported for transparency and are not part of the causal gate for this focused environment fix.