Skip to content

Feat/cif tracker enhancement #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imatul1996 merged 3 commits into from
May 22, 2026
Merged

Feat/cif tracker enhancement #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab1c1af
feat(cif-tracker): add role-based access control for CIF Tracker role
Rishabh-Rahangdale May 22, 2026
828872a
style(cif-tracker): shrink UI width and add modern soft shadows
Rishabh-Rahangdale May 22, 2026
ab41451
feat(cif-tracker): restrict CIF ID input to 9 numeric digits
Rishabh-Rahangdale May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 36 additions & 12 deletions custom_report/www/cif_tracker.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@
:root {
--primary: #196767;
--primary-hover: #145353;
--bg-color: #f4f7f7;
--bg-color: #f0f4f4;
--surface: #ffffff;
--border: #d1d8d8;
--border: #e1e8e8;
--text-main: #2c3e50;
--text-muted: #7f8c8d;
--radius: 8px;
--shadow: 0 4px 6px rgba(0,0,0,0.05);
--radius: 12px;
--shadow: 0 10px 30px rgba(0, 0, 0, 0.08), 0 4px 6px rgba(0, 0, 0, 0.04);
}

body {
Expand All @@ -26,31 +26,43 @@
margin: 0;
padding: 20px;
color: var(--text-main);
min-height: 100vh;
display: flex;
align-items: flex-start;
justify-content: center;
}

.container {
max-width: 1000px;
width: 100%;
max-width: 850px;
margin: 40px auto;
}

.card {
background: var(--surface);
padding: 30px;
padding: 35px;
border-radius: var(--radius);
box-shadow: var(--shadow);
border: 1px solid var(--border);
border: 1px solid rgba(25, 103, 103, 0.1);
}

.header {
text-align: center;
margin-bottom: 30px;
margin-bottom: 35px;
}

.header h2 {
margin: 0;
color: var(--primary);
font-size: 28px;
font-weight: 700;
font-size: 26px;
font-weight: 800;
letter-spacing: -0.5px;
}

.header p {
margin: 8px 0 0;
color: var(--text-muted);
font-size: 14px;
}

.search-box {
Expand Down Expand Up @@ -152,6 +164,7 @@
<body>

<div class="container" id="app" v-cloak>
{% if has_access %}
<div class="card">
<div class="header">
<h2>CIF Tracker</h2>
Expand All @@ -162,10 +175,12 @@ <h2>CIF Tracker</h2>
<input
type="text"
v-model="cif_id"
placeholder="Enter CIF ID (e.g. 1025488)"
maxlength="9"
placeholder="Enter 9-digit CIF ID"
@input="cif_id = cif_id.replace(/[^0-9]/g, '')"
@keyup.enter="fetchDetails"
>
<button @click="fetchDetails" :disabled="loading">
<button @click="fetchDetails" :disabled="loading || cif_id.length !== 9">
<span v-if="loading">Searching...</span>
<span v-else>Search</span>
</button>
Expand Down Expand Up @@ -200,6 +215,15 @@ <h2>CIF Tracker</h2>
</table>
</div>
</div>
{% else %}
<div class="card" style="text-align: center;">
<div style="font-size: 60px; margin-bottom: 20px;">🚫</div>
<h2 style="color: #e74c3c;">Access Denied</h2>
<p>You do not have permission to access the <b>CIF Tracker</b>.</p>
<p style="color: var(--text-muted); font-size: 14px;">Please contact your IT Administrator to request the 'CIF Tracker' role.</p>
<button onclick="window.location.href='/'" style="margin-top: 20px;">Back to Home</button>
</div>
{% endif %}
</div>

<script>
Expand Down
20 changes: 18 additions & 2 deletions custom_report/www/cif_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,27 @@ def get_context(context):
context.no_cache = 1
context.login_required = True

# Check if user is Administrator or has specific roles (optional, defaults to True for now)
context.has_access = True
# Check if user has "CIF Tracker" role
context.has_access = check_user_access()

def check_user_access():
"""Helper to check if user has 'CIF Tracker' or 'Administrator' access"""
user = frappe.session.user
if user == "Administrator":
return True

user_roles = set(frappe.get_roles(user))
if "CIF Tracker" in user_roles or "System Manager" in user_roles:
return True

return False

@frappe.whitelist()
def get_cif_details(cif_id):
# Security check for API call
if not check_user_access():
frappe.throw("Access Denied: You do not have the 'CIF Tracker' role.", frappe.PermissionError)

if not cif_id:
return {"success": False, "error": "CIF ID is required"}

Expand Down
Loading