Skip to content

Making internal time representation integer in units of nanoseconds. #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btasdelen wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Making internal time representation integer in units of nanoseconds. #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pypulseq/Sequence/sequence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,7 +1460,7 @@ def waveforms_and_times(

rf_piece = np.array(
[
curr_dur + rf.delay + rf.t,
np.rint((curr_dur + rf.delay + rf.t)*1e9), # [s] -> [ns]
rf.signal
* np.exp(
1j
Expand All @@ -1470,13 +1470,14 @@ def waveforms_and_times(
)
out_len[-1] += len(rf.t)

# If waveform does not start and end with 0, force it to 0 by adding 1ns shifted 0 on both sides.
if np.abs(rf.signal[0]) > 0:
pre = np.array([[rf_piece[0, 0] - 0.1*self.system.rf_raster_time], [0]])
pre = np.array([[rf_piece[0, 0] - 1], [0]])
rf_piece = np.hstack((pre, rf_piece))
out_len[-1] += pre.shape[1]

if np.abs(rf.signal[-1]) > 0:
post = np.array([[rf_piece[0, -1] + 0.1*self.system.rf_raster_time], [0]])
post = np.array([[rf_piece[0, -1] + 1], [0]])
rf_piece = np.hstack((rf_piece, post))
out_len[-1] += post.shape[1]

Expand Down Expand Up @@ -1534,6 +1535,9 @@ def waveforms_and_times(
if wave_cnt[j] < wave_data[j].shape[1]:
wave_data[j] = wave_data[j][:, : wave_cnt[j]]

# TMP: Convert RF time units [ns] -> [s].
# This will potentially cause repeating time points for long sequences due to floating-point precision issues.
wave_data[-1][0,:] = wave_data[-1][0,:]*1e-9
tfp_excitation = np.array(tfp_excitation).transpose()
tfp_refocusing = np.array(tfp_refocusing).transpose()
t_adc = np.array(t_adc)
Expand Down