fix: reset search loading state after navigation#38
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
|
@pragnyanramtha is attempting to deploy a commit to the rohanhake256's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Replaces the manual isLoading state in SearchForm with React's useTransition so the pending state is automatically cleared once navigation completes, fixing the stuck spinner bug described in #32. Also tightens the disabled state logic and adds accessible labels for the pending state.
Changes:
- Swap
useStateloading flag foruseTransition'sisPendingand wraprouter.pushinstartTransition. - Derive
trimmedQuery/canSearch/isSearchEnabledonce and reuse for guard, disabled, and styling logic. - Add
aria-labelandsr-only"Searching" text alongside the spinner for accessibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLoadingflag with React transition pending state for search navigationCloses #32.
Tests
npx eslint app/components/SearchForm.tsxnpm run buildgit diff --checkNote: full
npm run lintstill fails on pre-existing unrelated lint errors inabout/page.tsx,PriceMap.tsx,contact/page.tsx,page.tsx,search/page.tsx,proxy.ts, andutils/supabase/middleware.ts.