Merged
Conversation
Reduce the number of operations that the wpool_process needs to do on every loop: - Options get all its keys as mandatory, and will extract them all at once instead of on subsequent map gets in separate modules. - utils task_init and task_end are moved into wpool_process, as within the same module the JIT can optimise types, and readouts can be done all at once - task_end doesn't do erase(wpool_task) but put(wpool_task, undefined), as this way the process dictionary doesn't need any hash-table or bucket reshuffling, potentially. - notify_queue_manager chooses the function to call directly, instead of doing a dynamic call, it's more performant as it doesn't need to lookup the function pointer at runtime, instead it only needs to choose it based on a function clause of just 4 elements that are in the same module, so again, JIT can optimise more aggressively.
elbrujohalcon
approved these changes
Feb 21, 2026
Member
elbrujohalcon
left a comment
elbrujohalcon
left a comment
There was a problem hiding this comment.
I LOVE ❤️ this kind of pull requests! This is the type of PR I would never ever come up with, even if my life would depend on it.
Thank you, very much, @NelsonVides !
Member
|
Let me know if you want me to generate a new release… or, I'm not sure if you can, but if you can… go for it and generate/publish one yourself whenever you want. |
Collaborator
Author
|
Released and published, thank you very much for reviews 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the number of operations that the wpool_process needs to do on every loop: