Fix frictionless 2.0.0 issues - #221
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
===========================================
- Coverage 100.00% 99.69% -0.31%
===========================================
Files 28 29 +1
Lines 1295 1305 +10
===========================================
+ Hits 1295 1301 +6
- Misses 0 4 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Don't run check_package(): it's a helper function, it's expected to have correct input - Don't have downgrade_resource() helper function, keep it contained to one helper
peterdesmet
left a comment
There was a problem hiding this comment.
Wait for public append function to keep the original order of the attributes, see frictionlessdata/frictionless-r#365
The frictionless::append() function won't help here, since it is intended to work on packages, not resources. So I started reviewing this already and made some changes.
Still need to figure out coverage drop.
Coverage can be restored once frictionless 2.0.0 is released:
|
|
Seems like my extra test didn't fix the coverage, so I removed it again. You're right that this should likely fix itself once frictionless 2.0.0 is out and v2 resources are created. |
Wait for public append function to keep the original order of the attributes, see frictionlessdata/frictionless-r#365