Skip to content

Fix frictionless 2.0.0 issues - #221

Merged
peterdesmet merged 9 commits into
mainfrom
fix-fricionless-2.0.0
Sep 9, 2026
Merged

peterdesmet merged 9 commits into
mainfrom
fix-fricionless-2.0.0

Conversation

@sannegovaert

Copy link
Copy Markdown
Member

Wait for public append function to keep the original order of the attributes, see frictionlessdata/frictionless-r#365

@sannegovaert sannegovaert changed the title Fix fricionless 2.0.0 Fix frictionless 2.0.0 issues Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.69%. Comparing base (cf1cd78) to head (113e269).

Files with missing lines Patch % Lines
R/downgrade_package.R 55.55% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #221      +/-   ##
===========================================
- Coverage   100.00%   99.69%   -0.31%     
===========================================
  Files           28       29       +1     
  Lines         1295     1305      +10     
===========================================
+ Hits          1295     1301       +6     
- Misses           0        4       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Don't run check_package(): it's a helper function, it's expected to have correct input
- Don't have downgrade_resource() helper function, keep it contained to one helper
@peterdesmet
peterdesmet self-requested a review September 9, 2026 12:08

@peterdesmet peterdesmet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for public append function to keep the original order of the attributes, see frictionlessdata/frictionless-r#365

The frictionless::append() function won't help here, since it is intended to work on packages, not resources. So I started reviewing this already and made some changes.

Still need to figure out coverage drop.

@sannegovaert

sannegovaert commented Sep 9, 2026 •

Copy link
Copy Markdown
Member Author

Still need to figure out coverage drop.

Coverage can be restored once frictionless 2.0.0 is released:

  • add test with an upgraded camtrapdp package

@peterdesmet

Copy link
Copy Markdown
Member

Seems like my extra test didn't fix the coverage, so I removed it again. You're right that this should likely fix itself once frictionless 2.0.0 is out and v2 resources are created.

@peterdesmet peterdesmet mentioned this pull request Sep 9, 2026
@peterdesmet
peterdesmet merged commit d61868c into main Sep 9, 2026
8 of 14 checks passed
@peterdesmet
peterdesmet deleted the fix-fricionless-2.0.0 branch September 9, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix issues introduced by frictionless 2.0.0

2 participants