Repository navigation
Fix time groups at calendar boundaries with group_time_by - #435
Merged
damianooldoni merged 2 commits intoOct 7, 2026
Merged
Conversation
Derive the start and end of the time groups in `create_date_series()` from one sequence of calendar boundaries, so deployments starting or ending on a boundary get correct time groups and effort. A deployment of zero duration on a boundary still returns one time group with zero effort. Match observations to the time group starting at or before `eventStart` in `enrich_observations()`, so an observation on a boundary is counted once. Fixes inbo#433
damianooldoni
self-requested a review
October 7, 2026 11:57
damianooldoni
approved these changes
Oct 7, 2026
Member
There was a problem hiding this comment.
Thanks @northfox for solving also this issue! The solution works well and doesn't add any complexity, on the contrary!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #433.
create_date_series(): build the time groups from one sequence of calendar boundaries, so deployments starting or ending on a boundary get correct effort. A zero-length deployment on a boundary still returns one time group with zero effort.enrich_observations(): replace thebetween()join with a rolling join, so observations are assigned to half-open time groups[start, next start)and an observation on a boundary is counted once. The last time group also includes its end, so an observation atdeploymentEndstays in it.main, pass here) and aNEWS.mdentry.In the GMU8_Leuven example from #433,
group_time_by = "day"now gives 483 observations, the same as without time grouping (previously 502).