Repository navigation
Release 0.4.0: open-issue fixes, upstream ports, extraction, frames and contributor readiness - #35
Merged
Merged
Conversation
EventTarget was an alias of Node, so window was not an EventTarget and a method saved on EventTarget.prototype never reached it. YouTube's Shady DOM polyfill does exactly that and threw on window.__shady_native_addEventListener.
fetch --eval, scrape --eval, MCP browser_evaluate and the SDK now share
Page::evaluate_checked: DevTools console semantics (statements return their
completion value, {a: 1} is an object, promises are awaited), one watchdog for
the run and the promise wait, and a thrown, rejected, unparsable or timed-out
evaluation is an error instead of null. fetch -e prints the error and exits
non-zero; scrape reports it in the URL's error field.
Page::evaluate returns Result and no longer hides errors behind a JS
try/catch; evaluate_or_null is the explicit choice for probes. Internal source
is read by the parser as an object literal, a block, or a function body.
CDP DOM and Input handlers propagate page-side failures, and two unused
error-swallowing Page wrappers are removed.
Top-level numbers are written as JSON.stringify writes them, so integers are
42, not 42.0, in every output path.
Closes #7, closes #8, closes #31.
…ia and CLI Frames: child frames are real CDP frames with their own execution contexts and isolated worlds; evaluation, DOM, box-model and Input commands reach into them; removing an iframe detaches it in the same command; a page's load event waits for its child frames; data: frames load; same-origin frames see the real parent, top and frameElement. Screenshots and PDFs paint iframe content. CDP: Accessibility returns one connected tree with ignored nodes and the query methods; Performance.getMetrics returns measured metrics; Emulation.setTimezoneOverride works per page without leaking to other pages; printToPDF dates use the page's zone; DOM.getBoxModel reports real boxes or the protocol error instead of a made-up box. Forms and editing: one entry-list construction for FormData and submission, select selectedness, text selection state and select-all input, and a radio set by script unchecks the rest of its group. Extract: a warnings field, scanned-page and encrypted-file reporting, --password, legacy .doc/.ppt detection, ISO dates, DOCX headers, footers, notes and comments, PPTX speaker notes, and aligned table cells. Media: MP4 edit lists and multichannel AAC with a downmix. OCR: equal tiles and seam merging. CLI and MCP: page script time limits with warnings, scrape reads stdin, --dump text and markdown follow the rendered structure, --selector narrows output to its match, fetch and scrape report and can wait for pending timers (--settle-timers), and the MCP server closes idle pages (--idle-timeout) and rejects non-2.0 JSON-RPC messages. Windows executables carry the Inbrowse icon and version details. README figures are our own measurements, and the obstacle course gains form, editing and iframe stages (38 stages). Closes #1, closes #2, closes #3, closes #4, closes #5, closes #6, closes #9, closes #10, closes #11, closes #12, closes #13, closes #14, closes #15, closes #16, closes #17, closes #18, closes #19, closes #20, closes #21, closes #22, closes #23, closes #24, closes #25, closes #26, closes #27, closes #28, closes #29, closes #30, closes #32, closes #33.
Upstream obscura fixes adapted to this tree: page scripts can no longer reach the internal op table through __bootstrap; @import with multibyte text, short SVG viewBox and grid span 0 no longer abort; the taffy grid loop ends; deep DOM no longer overflows the CDP stack; confirm() returns false; HTML serialization escaping; Storage after a replaced constructor; robots groups; custom element reactions; render invalidation; lifecycle replay; per-connection localStorage and IndexedDB merged back on close; PBKDF2 on blocking workers; setFileInputFiles validates before reading; stealth requests honour --user-agent; network idle uses the navigation timeout. Extraction: Markdown converter checked against adapted jina-ai/reader test cases (absolute URLs, hidden content dropped, code fence languages), boilerplate dropped by default with --boilerplate keep, fetch --dump json and MCP format json, deep pages without recursion limits. Frames: iframe documents load their stylesheets, images and fonts through the page pipeline, follow the iframe's content box, and about:blank or script-created iframes are frames at once. Small CSS backgrounds tile. Network: the plain HTTP client retries an idempotent request once when its connection fails or is reset before any response, like the stealth client. Dependencies: zstd, calamine and quinn-proto updated for advisories. Also: README covers the new features, and the Inbrowse logo places its two gray blades next to each other (plugin icon and Windows icon).
The plain HTTP client also retries an idempotent request when the server closes the connection before any response (hyper incomplete message, checked by type). The script fetch phase ends before the navigation deadline, so a script that has not arrived is reported by name instead of failing the navigation. CSS url() assets of a file: page are collected; the existing subresource gate still keeps them away from network pages. Windows builds link the static C runtime that V8's prebuilt library uses, removing LNK4098; Windows media builds use the x64-windows-static libvpx triplet. rustix 1.1.6 and lru 0.18.5 for RUSTSEC-2026-0486 and RUSTSEC-2026-0253.
DOM.requestNode again requires a Node of the realm that made the object; a plain object with a numeric _nid no longer resolves. A fetched iframe document is queued with the iframe's content box, the viewport the host keeps it at. An IndexedDB transaction whose task ended with no requests counts as finished, so objectStore() throws InvalidStateError whichever task runs before its commit. The navigation deadline now only ends the wait for script downloads; inline and arrived scripts keep the script budget. Tests that gave a queued task one short event-loop turn now pump until it arrives (bounded); the storage test closes its last connection before removing the profile; the module transport fixture drops the retried GET too; the runaway-script bound excludes engine start-up.
The file: document loader in inbrowse-js is compiled in every build, so ResourceRequest is imported unconditionally; the no-render build failed without it. A shadow-stylesheet helper used only by paint code is gated on paint, removing the dead-code warning without it. Three new tests that need layout or computed style (frame element geometry, frame accessibility visibility, stylesheet-hidden reader content) run in render builds only, like the existing page tests for the same.
CODEOWNERS names the Incord maintainer instead of obscura's. CONTRIBUTING explains the relationship to obscura (where to report bugs, how upstream fixes are ported, how to read old issue numbers) and links a new dev container; the commit example no longer cites an obscura issue number. The stray build.log, which leaked a local path, is removed and *.log is ignored. macOS and Windows render builds and tests run on every push to main. Refs #34
Found by the render-repros comparison with Chromium. The background shorthand reset the position and never read one, so `url() center` and sprite offsets drew from the top left. paint_image clipped only at the top and left edges, so a shifted tile grid painted past the right and bottom of its box. An SVG image with width and height but no viewBox kept its artwork at the intrinsic size when drawn larger; it now scales like Chrome, while inline SVG keeps its own viewport rules. background: 0 computes to 0px 50%, as in Chromium.
Formatting only, produced by cargo fmt on the 14 workspace crates; the vendored crates are unchanged. Listed in .git-blame-ignore-revs. Refs #34
scripts/ci/fmt.sh formats the workspace crates only (cargo fmt --all would also rewrite vendor/), and CI checks it. The formatting commit is listed in .git-blame-ignore-revs. AGENTS.md and CONTRIBUTING.md now ask for the formatter instead of forbidding it, and the dev container formats Rust on save. Refs #34
The implied viewBox now comes with preserveAspectRatio="none" (an author value, which has no effect without a viewBox, is replaced). A 720x424 SVG drawn at 354x208 was letterboxed by under a pixel and failed the replaced-block-wrapper render check; it now fills the box as in Chromium.
CHANGELOG section for 0.4.0 and plugin version 0.4.0. CI runs the obstacle course at incordai/Inbrowse-benchmark a0fff27, which adds the form submission, text editing and iframe stages (38 in total), and the comparison gate expects 38.
Member
Author
|
PR / Policy flags the two new vendored crates, vendor/moq-audio and vendor/symphonia-codec-aac (the multichannel AAC decoder for #25). They were approved by the maintainer when #25 was planned, so this PR is merged by the maintainer and the full Linux, macOS and Windows CI runs on the push to main. v0.4.0 is tagged only after that is green. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.4.0: fixes for the open issues, upstream obscura fixes, Jina-style extraction, frames, and contributor readiness.
Issues are referenced, not closed: each is closed after it is confirmed.
Refs #1 #2 #3 #4 #5 #6 #7 #8 #9 #10 #11 #12 #13 #14 #15 #16 #17 #18 #19 #20 #21 #22 #23 #24 #25 #26 #27 #28 #29 #30 #31 #32 #33 #34
Highlights
mcp --idle-timeout), JSON-RPC version checked.--dump json, Jina Reader conformance for markdown, boilerplate dropped by default (--boilerplate keep).Verification (Windows 11, local)
cargo nextest run --release --features render --no-fail-fast: 2931/2931--stealthcargo nextest ... --no-default-features: 1897/1897; SDK 31/31Note on the PR / Performance check
That job compares with the base branch's
scripts/ci/compare_obstacle.py, which expects 33 stages, while this PR moves the pinned course to 38 stages. The stage-count check fails once for this PR by design of the trusted-base gate; the latency comparison it uploads is reviewed by hand. Later PRs compare 38 with 38.