Repository navigation
desktop: incode names the incord-desktop crate directly; src/desktop.rs keeps only incode's part - #100
Merged
Conversation
…rs keeps only incode's part src/desktop.rs re-exported the whole incord-desktop crate (pub use incord_desktop::*) so the crate::desktop::... paths written before the desktop moved to crates/desktop (#93) kept working. Its header called rewriting them "a later step"; this is that step. - Every use of the crate's own items now names it: incord_desktop::journal, ::capture, ::limits, ::safety::stop_path_in, ::thread, ::mcp::Server and ::mcp::tool_definitions (admin, migrate, team, tool_bridge, cli, serve, the toolbox, main.rs). - src/desktop.rs no longer re-exports anything. It holds the three things that are incode's: the agent registration for `incode --desktop-mcp` (mcp::client_config, client_config_json, codex_config_overrides), the stop request behind incode's folder handling (safety::request_stop) and the `serve` wrapper. Those keep their crate::desktop paths. No behaviour changes. cargo clippy --all-targets: clean. cargo test --lib: 2290 passed, 0 failed. cargo test --bins: 59 passed, 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
desktop: incode names the incord-desktop crate directly; src/desktop.rs keeps only incode's part
src/desktop.rs re-exported the whole incord-desktop crate (pub use
incord_desktop::*) so the crate::desktop::... paths written before the
desktop moved to crates/desktop (#93) kept working. Its header called
rewriting them "a later step"; this is that step.
::capture, ::limits, ::safety::stop_path_in, ::thread, ::mcp::Server and
::mcp::tool_definitions (admin, migrate, team, tool_bridge, cli, serve,
the toolbox, main.rs).
that are incode's: the agent registration for
incode --desktop-mcp(mcp::client_config, client_config_json, codex_config_overrides), the stop
request behind incode's folder handling (safety::request_stop) and the
servewrapper. Those keep their crate::desktop paths.No behaviour changes. cargo clippy --all-targets: clean. cargo test --lib:
2290 passed, 0 failed. cargo test --bins: 59 passed, 0 failed.