Skip to content

desktop: incode names the incord-desktop crate directly; src/desktop.rs keeps only incode's part - #100

Merged
blockmandev merged 1 commit into
mainfrom
refactor/desktop-paths
Nov 15, 2026
Merged

blockmandev merged 1 commit into
mainfrom
refactor/desktop-paths

Conversation

@blockmandev

Copy link
Copy Markdown
Member

desktop: incode names the incord-desktop crate directly; src/desktop.rs keeps only incode's part

src/desktop.rs re-exported the whole incord-desktop crate (pub use
incord_desktop::*) so the crate::desktop::... paths written before the
desktop moved to crates/desktop (#93) kept working. Its header called
rewriting them "a later step"; this is that step.

  • Every use of the crate's own items now names it: incord_desktop::journal,
    ::capture, ::limits, ::safety::stop_path_in, ::thread, ::mcp::Server and
    ::mcp::tool_definitions (admin, migrate, team, tool_bridge, cli, serve,
    the toolbox, main.rs).
  • src/desktop.rs no longer re-exports anything. It holds the three things
    that are incode's: the agent registration for incode --desktop-mcp
    (mcp::client_config, client_config_json, codex_config_overrides), the stop
    request behind incode's folder handling (safety::request_stop) and the
    serve wrapper. Those keep their crate::desktop paths.

No behaviour changes. cargo clippy --all-targets: clean. cargo test --lib:
2290 passed, 0 failed. cargo test --bins: 59 passed, 0 failed.

…rs keeps only incode's part

src/desktop.rs re-exported the whole incord-desktop crate (pub use
incord_desktop::*) so the crate::desktop::... paths written before the
desktop moved to crates/desktop (#93) kept working. Its header called
rewriting them "a later step"; this is that step.

- Every use of the crate's own items now names it: incord_desktop::journal,
  ::capture, ::limits, ::safety::stop_path_in, ::thread, ::mcp::Server and
  ::mcp::tool_definitions (admin, migrate, team, tool_bridge, cli, serve,
  the toolbox, main.rs).
- src/desktop.rs no longer re-exports anything. It holds the three things
  that are incode's: the agent registration for `incode --desktop-mcp`
  (mcp::client_config, client_config_json, codex_config_overrides), the stop
  request behind incode's folder handling (safety::request_stop) and the
  `serve` wrapper. Those keep their crate::desktop paths.

No behaviour changes. cargo clippy --all-targets: clean. cargo test --lib:
2290 passed, 0 failed. cargo test --bins: 59 passed, 0 failed.
@blockmandev
blockmandev merged commit 9469c5f into main Nov 15, 2026
12 checks passed
@blockmandev
blockmandev deleted the refactor/desktop-paths branch November 15, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant