Repository navigation
main: each mode a step of its own; main is the order they are checked in - #101
Merged
Merged
Conversation
The auditor's findings b2aeaf49766292f1 (main spanned 304 lines) and 18b776aa2358b13b (cyclomatic complexity 53). main is now 40 lines: the insbx helper, sandbox_exec_if_asked, run_subcommand (review, plugin, lifecycle, remote, one function each), parse_args, carry_over_old_state, ignored_spec_gate and run_mode, whose arms each call one function (run_task, run_desktop_mcp, run_serve, ...). The order and every mode's body are unchanged, with their comments. cargo clippy --all-targets: clean. cargo test --bins: 59 passed. The built binary answers --version, review --help, plugin list and completions bash, and exits 1 on an unknown flag.
…k_run::run_task as uncalled The wiring scan matches callers by name. A main.rs function named run_task counted as a caller of task_run::run_task, whose only caller is a test, and the ratchet fell from 38 to 37 for nothing (PR 101's CI). Renamed, with the reason beside it; MAX_UNWIRED stays at 38. cargo test --lib: 2290 passed (wiring:: 10 passed). cargo test --bins: 59 passed. cargo clippy --all-targets: clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auditor's findings b2aeaf49766292f1 (main spanned 304 lines) and
18b776aa2358b13b (cyclomatic complexity 53). main is now 40 lines: the
insbx helper, sandbox_exec_if_asked, run_subcommand (review, plugin,
lifecycle, remote, one function each), parse_args, carry_over_old_state,
ignored_spec_gate and run_mode, whose arms each call one function
(run_task, run_desktop_mcp, run_serve, ...). The order and every mode's
body are unchanged, with their comments.
cargo clippy --all-targets: clean. cargo test --bins: 59 passed. The built
binary answers --version, review --help, plugin list and completions bash,
and exits 1 on an unknown flag.