Repository navigation
sbx: the Windows module doc says what is tested (closes #39) - #42
Merged
Merged
Conversation
It said nothing in the port had run on Windows; tests/escape_windows.rs runs on the windows-latest runner after sbx setup-windows, as the README already says.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc-only.
crates/sandbox/src/windows/mod.rssaid nothing in the port had run on Windows. It now says what the README already says:tests/escape_windows.rsruns on thewindows-latestCI runner aftersbx setup-windows. A grep ofcrates/sandbox/src/windows/found no other copy of the claim.Two similar sentences are about macOS and are left alone here:
crates/sandbox/src/seatbelt.rs:12andcrates/sandbox/README.md:164.