Repository navigation
sdk: list kept sessions, typed, here or in every workspace (refs #21) - #48
Merged
Merged
Conversation
session/list was wrapped only as raw objects for the session's own workspace, though incode answers for every workspace when no cwd is given. Session.sessions() / sessions() return SessionInfo (session id, cwd, title, updated at), newest first, with all_workspaces / allWorkspaces for the whole list; list_sessions / listSessions stay as they were. The fake now answers session/list as src/acp_agent does.
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21: a fuller
session/listhelper.The SDKs wrapped
session/listonly as raw objects for the session's own workspace, though incode answers for every workspace an ACP session was recorded in when nocwdis given (src/acp_agent/mod.rs,list_sessions).Session.sessions(all_workspaces=False)and TypeScriptsession.sessions({ allWorkspaces })returnSessionInfo: session id,cwd,title,updated_at/updatedAt, and the raw object.load/loadSessionId.list_sessions/listSessionsare unchanged.session/listbut didn't answer it. It now does, as incode does: bycwd, or every session it opened.Tests
One per SDK. Each checks:
updatedAt;The ordering assertion fails without the sort, because the fake lists
kept-sessionfirst; the all-workspaces assertion fails ifcwdis always sent.Local results: Python 44 OK (1 skipped); TypeScript 45/46 pass, 0 fail.