Repository navigation
ci: install each published release the way users do (refs #18) - #59
Merged
Merged
Conversation
…m (refs #18) install.sh had never run anywhere, and install.ps1 only by hand: nothing checked that a published release can actually be installed, or that the installed programs report the release's version (the drift #58 fixed). install-check.yml installs a tag's release with the installers from that tag -- install.sh on ubuntu-22.04 (x86_64 and arm) and macOS, install.ps1 on Windows -- into a private folder, and fails unless `incode --version` and `sbx --version` name exactly the tag's version. release.yml calls it after publishing (a release published with the workflow's token starts no `on: release` workflow); it also runs by hand for an existing tag.
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
install.shhas never run anywhere, and nothing checks that a published release can actually be installed, or that it reports its own version.Added:
install-check.yml, which installs a tag's release with that tag's own installers and fails unlessincode --versionandsbx --versionname the tag's version exactly:install.shon ubuntu-22.04 (x86_64 and arm) and macOS;install.ps1on Windows.release.ymlruns it right after publishing. It can also be run by hand:gh workflow run install-check.yml -f tag=v0.1.0-rc.2.Checked: both workflows parse and every bash step passes
bash -n. The workflow itself can only be run once it's onmain. Right after merging I'll run it forv0.1.0-rc.2, which has already been installed by hand on Windows: checksum verified, and it reports0.1.0-rc.2.