Repository navigation
deps: zip 9.5.1, calamine 0.38.0, rustls 0.23.46 (Dependabot #2-#10) - #86
Merged
Merged
Conversation
…#10) zip 8.6.0 (shipped: documents and the tool archives ext_tools unpacks) had advisories fixed in 9.0.5: a parser differential between its two headers (critical), extract() writing outside the target through a symlink, unbounded symlink targets and Shrink/Reduce/Implode sizes (high), an AES HMAC check skipped at early EOF (medium). calamine 0.38.0 is the first on zip 9 (0.36.1 needed zip ^8.6), so the spreadsheet reader leaves zip 8 too: one zip in the tree. rustls 0.23.45 -> 0.23.46 is a test-only dev-dependency (4 low/medium alerts). All MIT or MIT/Apache/ISC; MSRV 1.88 (toolchain 1.97). zip 9 returns an entry's name as a Result. ext_tools refuses an entry whose name it cannot read; the document reader skips one (it looks for known parts only). New test: a zip whose local header names `../e.txt` while the central directory names `fine.txt` (the critical advisory's shape) writes nothing outside the folder; control: the consistent archive unpacks. It guards a regression; it was not run against zip 8.6.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 9 open Dependabot alerts.
zipext_toolsarchive unpackingcalaminezipremains in the treerustlsToolchain is 1.97, so the 1.88 MSRV is fine. Version pins and reasons are recorded in
Cargo.toml.Code changes (zip 9 API)
ZipFile::name()andfile_names()returnResult.ext_tools/unpack.rsrefuses an entry whose name can't be read.tools/documents.rsskips such a name, because it only looks up known parts.Tests (Windows, local)
-D warnings(workspace) clean.cargo test --lib --bins: 2435 passed and 1 failed. The failure isacp_agent::flow_tests::session_new_answers_before_a_slow_server_has_listed_its_tools, a timing test that doesn't involve zip or calamine. Rerun alone it passed 3/3 (4.5 s each), so it fails under full-suite load.ext_toolstests (zip-slip, links, bounds, plain unpack, install end to end) plus a new one. The new test builds an archive whose local header names../e.txtwhile its central directory saysfine.txt, the critical advisory's shape, and checks that nothing is written outside the folder; a consistent archive is the control. It guards against regressions. It was not run against 8.6.0.tools::documentstests (workbooks to tables, long sheets, docx, the zip-bomb budget).