Repository navigation
Audit findings: toolbox gates and text dispatch split out, decide_and_run as named steps - #96
Merged
Merged
Conversation
…_run as named steps The code auditor's four approved findings: - toolbox/mod.rs was 2680 lines (limit 2500); it is 2375. The permission gates (the rules, the mode, the person to ask, the memory engine) moved unchanged to toolbox/gates.rs, and the text tools' dispatch to toolbox/dispatch.rs. - decide_and_run was 266 lines. It is now the gate sequence alone, each gate a named step: admit (the free checks), guard_protected, announce_or_refuse, tell_guards_said_yes and with_guidance. The order is unchanged. - dispatch_text had a complexity of 38. It is now three tables by family (file, session, memory tools) and the modules that own the rest; the shell, document conversion and recorder arms are helpers of their own. - fake_agy_child (test) was 102 lines: its no-server answer, the server start and the JSON-RPC pipe are helpers. cargo clippy --all-targets: clean. cargo test --lib: 2284 passed, 0 failed.
blockmandev
added a commit
that referenced
this pull request
Nov 15, 2026
…ls and PluginCall (#99) * plugins: the memory engine's plugin tool servers offered as PluginTools and PluginCall The second half of the Claude-plugins work (the first, reading plugins in the .claude-plugin layout, is #83). The owner's decision of 2026-10-30: build the incode side now, tested against a fake engine, and say plainly when a plugin's server answers 401 (blocked on sign-in) instead of failing silently. - The memory engine runs plugin MCP servers for the owner. A session asks it once for the index (incord_describe) and offers two tools: PluginTools (one line per server; a server's tools on request) and PluginCall (run one). An index, not every tool, per the engine owner's decision: every plugin's tools in the context cost 8,029 tokens more. - Both are Reach::Run, like every MCP tool: refused read-only, asked under prompt, refused when the engine cannot decide. - A server a local plugin already runs is left out of the index, so no server is started twice. Plugin skills are read from the engine too. - Not offered when the engine names no servers or does not answer. This was left uncommitted on 2026-10-30 in the claude-plugins worktree; it is ported onto current main (the one conflict was the module list in toolbox/mod.rs after #96). cargo clippy --all-targets: clean. cargo test --lib: 2290 passed, 0 failed, including the 5 engine_plugins tests against a fake engine. The ignored live test against the real engine passed here: it described the inbrowse server's 43 tools. * plugins: engine_plugins_tests formatted with rustfmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit findings: toolbox gates and text dispatch split out, decide_and_run as named steps
The code auditor's four approved findings:
gates (the rules, the mode, the person to ask, the memory engine) moved
unchanged to toolbox/gates.rs, and the text tools' dispatch to
toolbox/dispatch.rs.
gate a named step: admit (the free checks), guard_protected,
announce_or_refuse, tell_guards_said_yes and with_guidance. The order
is unchanged.
(file, session, memory tools) and the modules that own the rest; the
shell, document conversion and recorder arms are helpers of their own.
start and the JSON-RPC pipe are helpers.
cargo clippy --all-targets: clean. cargo test --lib: 2284 passed, 0 failed.