Repository navigation
insbx mcp removes its default insbx-mcp-<pid> root when the server stops - #97
Merged
Merged
Conversation
The default root (<temp>/insbx-mcp-<pid>) is the server's own, but it was
left behind, empty, by every server that ran. It is now removed when the
server stops, unless --keep was given; a --root the caller gave stays.
Only an empty folder is removed, so a sandbox that could not be deleted
stays where it is.
Ported from the unmerged a7d2677 (sbx-trial/mcp-root-cleanup, written
before sbx was renamed insbx). tests/mcp_root.rs fails without the change
("insbx-mcp-440 left behind") and passes with it, on Windows.
cargo clippy -p incord-sandbox --all-targets -- -D warnings: clean.
cargo test -p incord-sandbox: all passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insbx mcp removes its default insbx-mcp- root when the server stops
The default root (/insbx-mcp-) is the server's own, but it was
left behind, empty, by every server that ran. It is now removed when the
server stops, unless --keep was given; a --root the caller gave stays.
Only an empty folder is removed, so a sandbox that could not be deleted
stays where it is.
Ported from the unmerged a7d2677 (sbx-trial/mcp-root-cleanup, written
before sbx was renamed insbx). tests/mcp_root.rs fails without the change
("insbx-mcp-440 left behind") and passes with it, on Windows.
cargo clippy -p incord-sandbox --all-targets -- -D warnings: clean.
cargo test -p incord-sandbox: all passed.