Skip to content

insbx mcp removes its default insbx-mcp-<pid> root when the server stops - #97

Merged
blockmandev merged 1 commit into
mainfrom
fix/insbx-mcp-root-cleanup
Nov 15, 2026
Merged

blockmandev merged 1 commit into
mainfrom
fix/insbx-mcp-root-cleanup

Conversation

@blockmandev

Copy link
Copy Markdown
Member

insbx mcp removes its default insbx-mcp- root when the server stops

The default root (/insbx-mcp-) is the server's own, but it was
left behind, empty, by every server that ran. It is now removed when the
server stops, unless --keep was given; a --root the caller gave stays.
Only an empty folder is removed, so a sandbox that could not be deleted
stays where it is.

Ported from the unmerged a7d2677 (sbx-trial/mcp-root-cleanup, written
before sbx was renamed insbx). tests/mcp_root.rs fails without the change
("insbx-mcp-440 left behind") and passes with it, on Windows.
cargo clippy -p incord-sandbox --all-targets -- -D warnings: clean.
cargo test -p incord-sandbox: all passed.

The default root (<temp>/insbx-mcp-<pid>) is the server's own, but it was
left behind, empty, by every server that ran. It is now removed when the
server stops, unless --keep was given; a --root the caller gave stays.
Only an empty folder is removed, so a sandbox that could not be deleted
stays where it is.

Ported from the unmerged a7d2677 (sbx-trial/mcp-root-cleanup, written
before sbx was renamed insbx). tests/mcp_root.rs fails without the change
("insbx-mcp-440 left behind") and passes with it, on Windows.
cargo clippy -p incord-sandbox --all-targets -- -D warnings: clean.
cargo test -p incord-sandbox: all passed.
@blockmandev
blockmandev merged commit 8d662aa into main Nov 15, 2026
21 of 22 checks passed
@blockmandev
blockmandev deleted the fix/insbx-mcp-root-cleanup branch November 15, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant