This repository was archived by the owner on Jul 10, 2024. It is now read-only.
PROC-1334: Add library support for rule filtering#142
Open
josuf107 wants to merge 2 commits intoindeedeng:masterfrom
Open
PROC-1334: Add library support for rule filtering#142josuf107 wants to merge 2 commits intoindeedeng:masterfrom
josuf107 wants to merge 2 commits intoindeedeng:masterfrom
Conversation
vanhaxl
requested review from
stevenchen-indeed,
vanhaxl and
zacharygoodwin
josuf107
force-pushed
the
jira/PROC-1334
branch
from
812f7dc to
ef0d7e5
Compare
| import java.util.Set; | ||
| import java.util.Stack; | ||
|
|
||
| class NodeHunter implements NodeVisitor { |
Contributor
There was a problem hiding this comment.
can we add some javadoc in this class?
Author
| } | ||
| return inRange(version, start, end); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Given all those code will only be used outside the proctor library. https://indeed-pte.slack.com/archives/C1F00STA9/p1688590802320449?thread_ts=1688582115.448299&cid=C1F00STA9
Can we add java doc to each of those methods to explain it is not meant to be called inside proctor lib?
Contributor
There was a problem hiding this comment.
actually, can we create a subclass and only the subclass has those extra methods?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://bugs.indeed.com/browse/PROC-1334 for context.