Skip to content

bump all versions in js#69

Merged
pcarrier merged 4 commits intomainfrom
pcarrier/major-upgrades
Mar 31, 2026
Merged

bump all versions in js#69
pcarrier merged 4 commits intomainfrom
pcarrier/major-upgrades

Conversation

@pcarrier
Copy link
Copy Markdown
Contributor

No description provided.

@indent
Copy link
Copy Markdown

indent bot commented Mar 31, 2026

PR Summary

This PR bumps all JS dependencies to their latest major versions (React 18→19, TypeScript 5→6, Vite 6→8, @vitejs/plugin-react 4→6, vitest 3→4, jsdom 25→29) and adds a resolve.dedupe config for React to prevent duplicate instances from the alias-based monorepo setup.

  • Bumped React and React types from 18 to 19 in both js/react and js/web-app
  • Bumped TypeScript from 5 to 6, Vite from 6 to 8, @vitejs/plugin-react from 4 to 6
  • Bumped vitest from 3 to 4, @vitest/coverage-v8 from 3 to 4, jsdom from 25 to 29
  • Simplified version specifiers from ^X.Y.Z to ^X
  • Added resolve.dedupe: ["react", "react-dom"] in vite.config.ts to prevent duplicate React copies from source alias resolution
  • Updated package-lock.json and pnpm-lock.yaml to reflect new versions
  • blit-react peerDependencies remain >=18.0.0, preserving backward compatibility for downstream consumers

Issues

1 potential issue found:

  • vite-plugin-singlefile@^2 may not officially support Vite 8. If the plugin's peer dependencies don't include Vite 8, the production build could fail. Verify compatibility or check for a newer release. → Autofix
1 issue already resolved
  • forwardRef is deprecated in React 19 and will emit console warnings. Used in BlitTerminal.tsx and Overlay.tsx — should be migrated to the ref-as-prop pattern. (fixed by commit 4420fec)

CI Checks

All failures are caused by a stale npmDepsHash in nix/packages.nix. The web-app lockfiles changed due to the dependency upgrades, but the Nix hash (sha256-LluQX9Lpmt9nlJRJRByr0HWHTa4QEoe72Wz1hAiFeeQ=) was not updated to the new value (sha256-Qr0IqyQyBT6oj0MgMVNab9nCIeBBsU+26nAVYVGi8iA=). This cascades to all jobs that depend on blit-web-app (lint, test, build-debs, build-tarballs, e2e). The cancelled jobs (macos-latest, aarch64-linux) were cancelled due to the earlier failures.

Failing test (ubuntu-latest)→ Autofix
  • Nix hash mismatch for npm-deps: specified sha256-LluQX9Lpmt9nlJRJRByr0HWHTa4QEoe72Wz1hAiFeeQ= but got sha256-Qr0IqyQyBT6oj0MgMVNab9nCIeBBsU+26nAVYVGi8iA=. The npmDepsHash in nix/packages.nix needs to be updated.
Failing lint→ Autofix
  • Same npm-deps hash mismatch as test. Cascading failure from stale npmDepsHash in nix/packages.nix.
Failing build-tarballs (ubuntu-latest, x86_64-linux)→ Autofix
  • Same npm-deps hash mismatch. Cascading failure from stale npmDepsHash.
Failing build-debs (ubuntu-latest, x86_64-linux)→ Autofix
  • Same npm-deps hash mismatch. Cascading failure from stale npmDepsHash.
Failing e2e→ Autofix
  • Same npm-deps hash mismatch. Cascading failure from stale npmDepsHash.

⚡ Autofix All

@mgasner mgasner requested review from mgasner and removed request for mgasner March 31, 2026 20:03
@mgasner mgasner self-requested a review March 31, 2026 20:10
Copy link
Copy Markdown
Contributor

@mgasner mgasner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcarrier pcarrier merged commit 1351697 into main Mar 31, 2026
1 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants