Skip to content

List existing flow rule exceptions on gradebook-single#1416

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/list-flow-rule-exceptions
Draft

List existing flow rule exceptions on gradebook-single#1416
Copilot wants to merge 2 commits intomainfrom
copilot/list-flow-rule-exceptions

Conversation

Copy link
Contributor

Copilot AI commented Feb 26, 2026

  • Add flow_rule_exceptions context to view_single_grade in grades.py
  • Add deactivate_flow_exception view in views.py (POST-only, requires grant_exception permission)
  • Add URL pattern relate-deactivate_flow_exception in urls.py
  • Update gradebook-single.html template to show exceptions with summary info, visual styling for inactive ones, and per-rule deactivate buttons
  • Add ViewSingleGradeFlowRuleExceptionsTest and DeactivateFlowExceptionTest tests
  • Fix test_deactivate_get_not_allowed: pass course_identifier to get_default_instructor_user()
Original prompt

This section details on the original issue you should resolve

<issue_title>List existing flow rule exceptions on gradebook-single</issue_title>
<issue_description>- The list should show summary information on the exception.

  • Also show deactivated rules, but in a visual style that clarifies they're no longer active.
  • Also, offer a per-rule button to deactivate currently-active exceptions.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add list of flow rule exceptions for gradebook-single List existing flow rule exceptions on gradebook-single Feb 26, 2026
Copilot AI requested a review from inducer February 26, 2026 20:37
Co-authored-by: inducer <352067+inducer@users.noreply.github.com>
@inducer inducer force-pushed the copilot/list-flow-rule-exceptions branch from ea24f3f to 0223b94 Compare February 27, 2026 20:21
@inducer
Copy link
Owner

inducer commented Feb 27, 2026

@copilot There's a test failure:

        with self.temporarily_switch_to_user(
>               self.get_default_instructor_user()):
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E               TypeError: CoursesTestMixinBase.get_default_instructor_user() missing 1 required positional argument: 'course_identifier'

tests/test_grades/test_grades.py:1813: TypeError

Also please consider the AGENTS.md file in the root of the repository.

Co-authored-by: inducer <352067+inducer@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 27, 2026

@copilot There's a test failure:

        with self.temporarily_switch_to_user(

...

Fixed in 55af831get_default_instructor_user() now receives self.get_default_course_identifier() as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List existing flow rule exceptions on gradebook-single

2 participants