Skip to content

Pin eslint to ^8.57.1 to fix peer dependency conflict with eslint-config-airbnb-base#1425

Merged
inducer merged 2 commits intodependabot/npm_and_yarn/npm-a5aecb9d32from
copilot/sub-pr-1424
Mar 1, 2026
Merged

Pin eslint to ^8.57.1 to fix peer dependency conflict with eslint-config-airbnb-base#1425
inducer merged 2 commits intodependabot/npm_and_yarn/npm-a5aecb9d32from
copilot/sub-pr-1424

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

eslint-config-airbnb-base@15.0.0 requires eslint@"^7.32.0 || ^8.2.0", making it incompatible with the eslint v10 bump introduced in this PR.

Changes

  • Pin eslint to ^8.57.1 (latest v8) instead of ^10.0.2 to satisfy eslint-config-airbnb-base@15.0.0's peer dependency constraint
  • Update package-lock.json accordingly

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…-airbnb-base@15

Co-authored-by: inducer <352067+inducer@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump npm group with 17 updates Pin eslint to ^8.57.1 to fix peer dependency conflict with eslint-config-airbnb-base Mar 1, 2026
@inducer inducer marked this pull request as ready for review March 1, 2026 20:25
Copilot AI review requested due to automatic review settings March 1, 2026 20:25
@inducer inducer merged commit 4d76048 into dependabot/npm_and_yarn/npm-a5aecb9d32 Mar 1, 2026
15 checks passed
@inducer inducer deleted the copilot/sub-pr-1424 branch March 1, 2026 20:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the JS tooling dependencies to resolve an npm peer-dependency conflict between eslint-config-airbnb-base@15.0.0 and an ESLint v10 bump, ensuring installs and CI linting remain functional.

Changes:

  • Downgrade/pin eslint to ^8.57.1 to satisfy eslint-config-airbnb-base@15.0.0 peer requirements.
  • Regenerate package-lock.json to reflect the ESLint v8 dependency tree.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Pins ESLint to v8 to satisfy Airbnb base config peer dependency constraints.
package-lock.json Updates the lockfile to align with ESLint v8 and its transitive dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 66 to 69
"autoprefixer": "^10.4.27",
"eslint": "^10.0.2",
"eslint": "^8.57.1",
"eslint-config-airbnb-base": "^15.0.0",
"eslint-plugin-import": "^2.32.0",
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint@8.57.1 is EOL/unsupported (and is marked deprecated in the lockfile), so pinning to it to satisfy eslint-config-airbnb-base@15 leaves the toolchain on an unmaintained major. If this is intentional/temporary, please add an explicit note in package.json (similar to the existing //... comment keys) and ideally a tracking issue to migrate to a config that supports a maintained ESLint major (or update the Airbnb config when possible).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants