Conversation
What is the original license? A quick skim didn't tell me.
I will not touch anything GPL'd with a 20-foot pole. |
|
Well - the license is right there in the repo: https://github.com/bitnami-labs/sealed-secrets/blob/main/LICENSE |
Ah. Didn't realize I was looking at a subfolder. Thanks!
I'm sorry you feel that way! I'll quickly try to explain why I try to keep my licensing liberal:
|
|
I have never been in a company that did not highly appreciate contributing to GPL projects. |
|
I can understand the attitude as an individual - and it highly depends on wether or not you're building a "library" or not.. (thats why there's the LGPL from that family of licenses ;) - a project such as relate is a standalone product - so its not really something I would worry about "infecting" other software - and IMHO it makes only sense to run on 100% Open Source - and when we don't live of selling software - there will never be any "infection problem" for us - and we are free to focus on upstreaming all improvements we do, first (everyone here is told to do so) - and we, and the customers we help, benefit highly from others doing the same. |
|
Thanks for working on this! Is there a way to exercise this in CI? I ask because I think it would be useful to notice in case it gets broken. |
|
I know some spin up k3s in CI - as its lightweight enough - to be used for testing - so that should be possible. |
|
We finally got Relate up and running for us again.. and now have new usecases for internal education :) A colleague will be adding improvements we've made for this - to this PR. I've also clarified that upstream is Apache 2.0 license - so that can be used or GPLv3 at your perogative. This is allowed as explained here: https://www.apache.org/licenses/GPL-compatibility.html |
|
I was thinking of using this action to test helm chart. Would that be acceptable to you? https://github.com/helm/chart-testing-action |
|
Yes, that sounds perfectly fine. I'm just worried about adding code that isn't tested, because then I have no way to even tell whether it has bitrotted. |
…rom Zalando to CNPG
Update Dockerfile for Python 3.10 support and switch PGSQL operator from zalando to cnpg
inducer
left a comment
There was a problem hiding this comment.
Thanks for working on this. Some comments below.
There was a problem hiding this comment.
Could you add a bit in the actual documentation (under doc/) that points to this README? (i.e. where it would end up living in the Relate repo)
There was a problem hiding this comment.
It seems ruff is a bit irritated by the syntax in this file. Could you hide it from the linter?
| WORKDIR /var/www/relate | ||
| RUN git pull | ||
| RUN poetry install | ||
| RUN npm install ; npm run build |
There was a problem hiding this comment.
See update.sh in the project root for a concise way to run all required steps.
| RUN git pull | ||
| RUN poetry install | ||
| RUN npm install ; npm run build | ||
| RUN poetry run pip install psycopg2 |
There was a problem hiding this comment.
| RUN poetry run pip install psycopg2 |
| ENV VENV_PATH=/var/www/relate-venv | ||
| WORKDIR /var/www/relate | ||
| RUN git pull | ||
| RUN poetry install |
There was a problem hiding this comment.
| RUN poetry install | |
| RUN poetry install -E postgres -E memcache |
| ENV VENV_PATH=/var/www/relate-venv | ||
| WORKDIR /var/www/relate | ||
| RUN git pull | ||
| RUN poetry install |
There was a problem hiding this comment.
On that note, memcached can be helpful (though it is not required).
First edition of relate Helm chart and Dockerfile - "works for me" mode :)
Pls review, ask and we can take it from there.
NB. This is based off of https://github.com/bitnami-labs/sealed-secrets/tree/main/helm/sealed-secrets - and I've removed a lot of irrelevant stuff and added some.. but the original license still applies I'd say. I prefer GPLv3 myself - but either will do here.
To clarify: Since this is based off of bitnami's chart - the chart would be under the Apache 2.0 license (just as upstream) - so its fine if both that and the improved dockerfile is under that.
PR sponsored by Obmondo.com