fix: correct month names localization in Datepicker#547
Conversation
|
Hello @LeonidShv! 🙇 However, I see an inconsistency in the main Description. You've written that:
I don't see any new watcher added. Is that up to date? |
Hi @AlanLes , Maybe I didn’t explain it very well. First, I added the watcher in the first commit. Then, in the second commit, I removed this watcher as part of a small refactoring. I’d be happy if you could share some links to your internal resources — maybe a task board, code style guide, or commit naming convention. |
|
@LeonidShv, yes, please squash it, and let's make this PR full-blown 😄 👍 Regarding our internal resources, I'm afraid all our resources are, as you wrote, internal. Most of the docs are on our Confluence, which is restricted to Infermedica's employees. However, I believe the docs should be sufficient for you. The most crucial information is there. 🙂 Thanks for your contribution! 🙇 |
…Names ref with computed
d29521c to
f8b7d24
Compare
|
@AlanLes Regarding to the documents and code style, I will try to compare my PRs with existed closed on. Thanks for your time : ) |
|
@LeonidShv, I still don't see any watcher added here.
|
|
@AlanLes After squashing the commits, the watcher is no longer present |
AlanLes
left a comment
There was a problem hiding this comment.
Awesome, the code looks good 😄 👍
@DanielHajduk98 @sonya0504 @pspaczek @mateuszkulpa, would you guys like to see and approve, or add any comments to it?
|
@AlanLes Thank you for the feedback! I hope my next PR will be clearer : ) |
|
@LeonidShv sure, I've approved it. Let's wait for another approval from someone from the team. @sonya0504 @DanielHajduk98 @kubajmarek @pspaczek @mateuszkulpa @jbucior? :) |
|
I don't think my or Przemek's approval would be useful here, as it doesn't have much power after org removal. 😉 |

Description
I've fixed a part of the published issue: "Data picker behaviour with non-English".
When you change the language, the months in the date picker didn’t update and showed incorrect translations.
Commits:
fix: correct month names localization in Datepicker and replace monthNames ref with computed
→ I've made monthNames a computed property that updates automatically when props.lang changes
The issue with the capitalization of the first letter in month names is not fixed in this PR.
I plan to address it in a separate fix after this PR is successfully merged.
Related Issue
"Issue 526: Data picker behaviour with non-English".
steps to reproduce:
Go to https://component.infermedica.com/?path=/story/organisms-datepicker--full-configuration
Click on props.lang
Select any language other than en or en-us
See that nothing changes in Month tab
Closes #
Motivation and Context
"Issue 526: Data picker behaviour with non-English".
When changing the language, the months in the date picker didn’t update and showed incorrect translations.
How Has This Been Tested?
You can test it by using the DatePicker component and changing the lang prop.
Example:
Screenshots (if appropriate):
Screen.Recording.2025-04-18.at.20.40.41.mov
Checklist: