feat: add mouseModifiers parameter to setupLocatorUI - #192
Draft
Strajk wants to merge 1 commit into
Draft
Conversation
- Add mouseModifiers option to setup() function - Allow configuring keyboard shortcuts (e.g., 'meta+shift' for Cmd+Shift+Click) - Maintains backward compatibility (defaults to 'alt' if not specified) - Supports any combination of alt, ctrl, meta, shift modifiers
|
@Strajk is attempting to deploy a commit to the Michael Musil's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
mouseModifiersparameter to thesetupLocatorUI()function, allowing users to configure custom keyboard shortcuts when using Locator without the browser extension.Changes
mouseModifiers?: stringparameter tosetup()function inpackages/runtime/src/index.tsinitRuntime()to accept and set the mouse modifiers viadocument.documentElement.dataset.locatorMouseModifiersUsage
Available Options
'alt'- Option/Alt + Click (default)'meta'- Cmd/Windows + Click'shift'- Shift + Click'ctrl'- Ctrl + Click'meta+shift'- Cmd+Shift + Click'meta+alt'- Cmd+Option + Clickalt,ctrl,meta,shiftjoined by+Motivation
This feature parity with the browser extension allows users who manually inject the Locator UI to customize keyboard shortcuts according to their preferences, avoiding conflicts with other tools or personal workflow preferences.