Move demo/test projects to test-apps/ and isolate from main pipelines - #209
Merged
Conversation
Relocates the 10 demo apps (vite-*, next-*) from apps/ to test-apps/ so they no longer share formatting, build, lint, typecheck, or dependency-version-consistency checks with the shipped packages and apps (web, extension). Playwright continues to run them via pnpm workspace filters and the new test-apps:dev script. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Playwright expects the web app on port 3342; the previous pnpm dev & step was covering it implicitly. After scoping pnpm dev to packages+apps and introducing pnpm test-apps:dev, the e2e job needs to launch both. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relocates the 10 demo apps (vite-* and next-*) from
apps/into a newtest-apps/directory and removes them from the main monorepo pipelines.packages/*,apps/web,apps/extension, andapps/playwrightno longer share formatting, build, lint, typecheck, or dependency-version checks with the test-apps, so PRs touching the shipped code stay focused. Playwright keeps running them via a newpnpm test-apps:devscript and the existing workspace-name filters.Changes
test-apps/viagit mv(history preserved) and addtest-apps/*topnpm-workspace.yaml+ rootworkspacesbuild/dev/lint/test/tsscripts to./packages/*+./apps/*; addtest-apps:devandtest-apps:build{packages,apps}, addtest-appsto.prettierignore, and switchcheck-dependency-version-consistencyto--ignore-path-pattern='^test-apps/'(path-based so it survives renames)pnpm test-apps:dev;apps/playwright/tests/libs/next16.spec.tsfile-path regex updated totest-apps/next-16-turbopack/Test plan
format/build/ts/lint/testjobs pass and only touch packages + appse2ejob starts all 9 test-app ports and Playwright suite passespnpm installstill resolves@locator/runtimeetc. inside test-apps viaworkspace:^🤖 Generated with Claude Code