Repository navigation
Mark LIBRARY_MERGE_PLAN complete; consolidate the Shier affine map - #161
Merged
Merged
Conversation
- LIBRARY_MERGE_PLAN.md: add a completion status note (all eleven domain trains merged, PRs verified byte-identical; scope deltas vs the plan sketches documented, notably data_qc_io's units/metrics/align/pay files superseded by existing canon; non-bit-reproducible corpus forms stay local by design). - petrolib/data_qc_io/scale.py: normalize_to_reference now applies its affine map via ml_stats.affine_rescale instead of duplicating the expression. The two arrangements multiply in commuted order, which is bit-identical in IEEE arithmetic; verified over 600 randomized cases (np.array_equal) across the explicit-endpoint, percentile, and min/max paths, plus golden_diff on the three adopting directories (src2015_04, src2016_12, src2021_12). Gates: ruff + mypy clean; 252 tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B2BX1XL8422gebCU1oVoQC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrap-up PR after the final adoption chunk (#160):
data_qc_iounits.py/metrics.py/align.py/pay.pyfiles were dropped as already covered bypetrolib.units,petrolib.ml_stats,petrolib.depth_matching, andpetrolib.porosity_lithology— and the deliberate policy that non-bit-reproducible corpus forms (additive guard variants, scipy-kernel smoothers, legacyRandomStategenerators) stay local to their articles.normalize_to_referencenow applies its affine map viaml_stats.affine_rescaleinstead of duplicating the expression — the one overlap introduced by the data_qc_io PR-A. The two arrangements differ only in commuted multiplication order, which is bit-identical in IEEE arithmetic.Verification
np.array_equal) across all three endpoint paths (explicit, percentile default,pct=Nonemin/max).python3 tools/golden_diff.pyon the three adopting directories (src2015_04, src2016_12, src2021_12): 3/3 PASS.ruff check+ruff format --checkclean;python3 -m mypy petrolibclean (45 source files);python3 -m pytest tests/petrolib: 252 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01B2BX1XL8422gebCU1oVoQC