fix: resolve all clippy warnings across workspace

crates/bor-chainspec/src/genesis.rs

@@ -6,7 +6,6 @@ use reth_chainspec::ChainSpecBuilder;
 use reth_ethereum_forks::{ChainHardforks, EthereumHardfork, ForkCondition};
 
 use crate::chainspec::{BorChainSpec, bor_mainnet_chainspec};
-use crate::BorHardfork;
 
 /// Berlin and London activated together on Polygon PoS mainnet.
 const BERLIN_BLOCK: u64 = 29_231_616;
@@ -40,6 +39,7 @@ pub fn bor_mainnet_genesis() -> BorChainSpec {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::BorHardfork;
     use reth_chainspec::EthChainSpec;
     use reth_ethereum_forks::Hardforks;
 

crates/bor-consensus/src/block_validation.rs

@@ -3,7 +3,7 @@
 //! Pre-execution validation checks body constraints, extra data at span starts, and seal.
 //! Post-execution validation verifies state root, receipt root, and gas used.
 
-use alloy_primitives::{Address, B256, U256};
+use alloy_primitives::{Address, B256};
 use crate::extra_data::ExtraData;
 use crate::validation::ValidationError;
 

crates/bor-consensus/src/snapshot.rs

@@ -1,7 +1,7 @@
 //! Bor consensus snapshot: tracks validator set and recent signers at a block.
 
 use alloy_primitives::{Address, B256};
-use bor_primitives::{Validator, ValidatorSet};
+use bor_primitives::ValidatorSet;
 use std::collections::BTreeMap;
 
 /// Snapshot of the Bor consensus state at a given block.
@@ -65,6 +65,7 @@ impl BorSnapshot {
 mod tests {
     use super::*;
     use alloy_primitives::address;
+    use bor_primitives::Validator;
 
     fn test_validator(id: u64, addr: &str) -> Validator {
         let a = addr.parse::<Address>().unwrap();

crates/bor-consensus/src/validation.rs

@@ -11,7 +11,7 @@
 //! - Signer must not have signed recently (anti-double-sign)
 
 use alloy_primitives::{Address, B256, U256};
-use crate::difficulty::{calculate_difficulty, is_inturn};
+use crate::difficulty::calculate_difficulty;
 use crate::extra_data::ExtraData;
 use crate::seal::ecrecover_seal;
 
@@ -131,7 +131,7 @@ pub fn validate_header(
     // 8. Anti-double-sign: signer must not have signed recently
     let limit = (authorized_signers.len() / 2 + 1) as u64;
     let cutoff = params.number.saturating_sub(limit);
-    for (&block, &recent_signer) in recent_signers.range(cutoff..params.number) {
+    for (&_block, &recent_signer) in recent_signers.range(cutoff..params.number) {
         if recent_signer == signer {
             return Err(ValidationError::RecentlySigned(signer));
         }

crates/bor-evm/src/config.rs

@@ -7,6 +7,7 @@ use bor_chainspec::BorHardfork;
 pub const P256_VERIFY_ADDRESS: Address = address!("0000000000000000000000000000000000000100");
 
 /// KZG point evaluation precompile address (never active on Bor).
+#[cfg(test)]
 const KZG_ADDRESS: Address = address!("000000000000000000000000000000000000000a");
 
 /// BorEvmConfig holds chain spec for fork-aware EVM configuration.

crates/bor-node/src/node.rs

@@ -1,9 +1,9 @@
 //! BorNode: wires all components together.
 
-use alloy_primitives::{Address, B256};
+use alloy_primitives::B256;
 use bor_chainspec::BorChainSpec;
 use bor_consensus::BorSnapshot;
-use bor_storage::persistence::{InMemorySpanStore, InMemorySnapshotStore, SpanStore, SnapshotStore};
+use bor_storage::persistence::{InMemorySpanStore, InMemorySnapshotStore, SnapshotStore};
 use crate::config::{BorNodeConfig, BorNetwork};
 use std::sync::{Arc, RwLock};
 
@@ -67,6 +67,7 @@ impl BorNode {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use alloy_primitives::Address;
     use bor_primitives::{Validator, ValidatorSet};
 
     fn test_validator_set() -> ValidatorSet {

crates/bor-payload/src/builder.rs

@@ -4,7 +4,7 @@
 //! sprint/span boundaries, and constructs the complete block payload.
 
 use alloy_primitives::{Address, Bytes, U256};
-use bor_evm::{SystemTxPlan, plan_system_txs, execute_system_tx_plan, SystemCallRecord};
+use bor_evm::{plan_system_txs, execute_system_tx_plan, SystemCallRecord};
 
 /// Configuration for building a payload.
 #[derive(Debug, Clone)]

crates/bor-storage/src/receipt_key.rs

@@ -15,7 +15,7 @@ pub fn bor_receipt_key(block_hash: &B256) -> B256 {
 
 /// Compute the legacy Bor receipt key from block number
 pub fn bor_receipt_key_legacy(block_number: u64) -> B256 {
-    alloy_primitives::keccak256(&block_number.to_be_bytes())
+    alloy_primitives::keccak256(block_number.to_be_bytes())
 }
 
 #[cfg(test)]

crates/bor-storage/src/tables.rs

@@ -20,7 +20,7 @@ pub const BOR_TABLES: &[&str] = &[
 /// BorReceipts: B256 (receipt_key) -> Vec<u8> (RLP bytes)
 /// BorTxLookup: B256 (tx_hash) -> (u64, u64) (block_number, tx_index)
 /// BorMeta: u64 (meta_key) -> u64 (value)
-
+///
 /// Meta keys
 pub const META_LAST_SPAN_ID: u64 = 0;
 pub const META_LAST_SNAPSHOT_BLOCK: u64 = 1;

crates/heimdall-client/src/cache.rs

@@ -41,8 +41,8 @@ impl SpanCache {
         let span_id = span.id;
 
         // If already present, update in place and promote.
-        if self.spans.contains_key(&span_id) {
-            self.spans.insert(span_id, span);
+        if let std::collections::hash_map::Entry::Occupied(mut e) = self.spans.entry(span_id) {
+            e.insert(span);
             self.touch(span_id);
             return;
         }