chore: update for parmigiana #30
Open
+215
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanlott
changed the title
Contributor
Author
|
Tested and confirmed that the roundtrip bin lands bundles of host and rollup transactions and notifies when they're confirmed. |
Contributor
Author
|
Rollup example isn't running though - need to diagnose but I suspect it's more contract permissions issues. |
Contributor
Author
|
Script has been updated and is confirmed working against Parmigiana test net. |
Member
|
should this be marked as rfr? |
Evalir
reviewed
Jan 9, 2026
| @@ -77,19 +80,23 @@ fn get_example_order( | |||
| .with_deadline(Utc::now().timestamp() as u64 + (60 * 10)); | |||
|
|
|||
| if rollup { | |||
Member
There was a problem hiding this comment.
i think we could simplify this a bit by getting the corresponding weth address and chain id before we construct the unsigned order, as that's the only thing that really changes
Evalir
reviewed
Jan 21, 2026
|
|
||
| /// Fill example [`SignedOrder`]s from the transaction cache. | ||
| #[instrument(skip_all, fields(target_order_signature = %target_order.permit.signature, target_order_owner = %target_order.permit.owner))] | ||
| #[instrument(skip_all, fields(target_order_signature = %target_order.permit().signature, target_order_owner = %target_order.permit().owner))] |
Member
There was a problem hiding this comment.
orders since a bit ago now have a hash we can use as an identifier, so we can skip having all these fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update for parmigiana
Closes ENG-1625.