feat(signet-orders): provide traits #170
Merged
+110
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraser999
commented
Jan 27, 2026
prestwich
approved these changes
Jan 27, 2026
| fn submit_order( | ||
| &self, | ||
| order: SignedOrder, | ||
| ) -> impl Future<Output = Result<(), Self::Error>> + Send; |
Member
There was a problem hiding this comment.
should this be AFIT? or do we want to mandate Send?
Contributor
Author
There was a problem hiding this comment.
Hmm - good question! I defaulted to mandating Send just because that's what I'm generally used to (multi-threaded tokio runtime specifically). I'm not sure if there are expected use cases where this would be a problem, but if not, I'd lean towards mandating Send.
Member
There was a problem hiding this comment.
in my experience the main place this causes problems is use in wasm, which is not a priority for use. I'm fine mandating Send
Evalir
approved these changes
Jan 27, 2026
Evalir
reviewed
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces three new traits to support submitting orders or bundles and fetching orders.