Add support for category description for PunBB#1
Open
michalpodlecki wants to merge 2 commits intoinitforthe:masterfrom
Open
Add support for category description for PunBB#1michalpodlecki wants to merge 2 commits intoinitforthe:masterfrom
michalpodlecki wants to merge 2 commits intoinitforthe:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Is it worth using topic.category as the description as well, if topic.category_desc is nil/not provided? Or should we just create it without a description in that case. Thinking of other forums here.
Author
There was a problem hiding this comment.
In my opinion the description should stay empty if there is no data for this field. Duplication is redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a category description which depends on
forum_descfield in PunBB database.